Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP-119: Location Trust Score from maximum asserted distance difference #840

Merged
merged 19 commits into from
Jul 17, 2024

Commits on Jul 9, 2024

  1. Calculate Location Trust Score from asserted distance in heartbeat

    HIP-119 introduces a new set of tables for location trust scores based on `(radio_type, distance_to_asserted)`.
    
    This also allows for a new minimum trust score multiplier of `0x`.
    michaeldjeffrey committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    4616f1b View commit details
    Browse the repository at this point in the history
  2. Remove use of max_distance_to_asserted

    This value is now contained within the function `asserted_distance_to_trust_multiplier` in the coverage point calculator.
    michaeldjeffrey committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    f48cbb2 View commit details
    Browse the repository at this point in the history
  3. Update test for increased allowable location trust multipliers

    All location trust scores used to be 1.0 or 0.25. HIP-119 adds 0.00 as a multiplier possibility based on distance.
    michaeldjeffrey committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    8e9b254 View commit details
    Browse the repository at this point in the history
  4. typo in test name

    michaeldjeffrey committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    48167e5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5f3d97c View commit details
    Browse the repository at this point in the history
  6. Pass location trust to determine boost eligibility

    Location Trust Scores are no longer reduced based on the presence of a
    boosted hex. However, having an average distance from an asserted
    location past 50m can cause a radio to be ineligible for boosted rewards.
    michaeldjeffrey committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    63d2881 View commit details
    Browse the repository at this point in the history
  7. namespace location consts to provide more context

    Both constants have to do with service provider boosting in regards to a
    radios location trust scores. Namespacing allows for not needing to
    shove all possible context into a top level name.
    michaeldjeffrey committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    41222c0 View commit details
    Browse the repository at this point in the history
  8. make service provider boosting module

    It didn't feel quite correct to have half the service provider boosting
    code in lib.rs and the other in location.rs.
    
    The constants have to with location trust scores, but they do not get
    used there.
    michaeldjeffrey committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    480690f View commit details
    Browse the repository at this point in the history
  9. Remove trust score tests that expect score modification from boosting

    The distance to asserted no longer changes trust scores in the presence
    of a boosted hex. Service provider boosting eligibility is determined
    from the distance to asserted, that is tested at the top level of this crate.
    michaeldjeffrey committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    f16bfa8 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    159b0b3 View commit details
    Browse the repository at this point in the history
  11. consolidate seeding heartbeats v1 and v3

    The only difference was the location distance from asserted and assigned
    location trust multipliers.
    
    Refactoring heartbeat seeding further is left as an exercise to the next
    person who has a need to change these tests.
    michaeldjeffrey committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    e5b68cd View commit details
    Browse the repository at this point in the history
  12. Test being too far from asserted location removes service provider bo…

    …osting
    
    HIP-119 removes the part of calculating coverage points that degrades a
    trust score when a radio covers a boosted hex and is more than 50m away
    from their asserted location.
    
    Now, being +50m away from an asserted location makes a radio not
    eligible for receiving service provider boosted rewards. They continue
    to receive the full force of their location trust score.
    
    Being an Indoor radio 100m away from an asserted location is enough to
    keep a location trust multiplier of 1.0x, but not receive boosted rewards.
    michaeldjeffrey committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    fbfeb65 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Configuration menu
    Copy the full SHA
    051f289 View commit details
    Browse the repository at this point in the history
  2. Try to link to relevant hips when possible

    Adding links to multiple places so you don't have to know a secret
    location where they exist.
    michaeldjeffrey committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    adb6439 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Configuration menu
    Copy the full SHA
    3d7a1cd View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Configuration menu
    Copy the full SHA
    1a0d007 View commit details
    Browse the repository at this point in the history
  2. Remove answered questions

    Both were answered yes
    michaeldjeffrey committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    dab79b8 View commit details
    Browse the repository at this point in the history
  3. New location scores apply to Wifi only

    CBRS is always trusted for location. The location trust score is intercepted earlier when validating heartbeats. If for some reason CBRS radios do make it to this function, they will receive a good trust score anyways.
    michaeldjeffrey committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    c3e8194 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    861bd8f View commit details
    Browse the repository at this point in the history