Coverage Point Calculator Integration with mobile-verifier #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will help with the switchover
This makes coverage points async internally. When cleanup is done there will be a single instance of CoveragePoints.
thresholds being met for a radio are not only about subscribers.
It's the responsibility of the report to only include hexes with active boost values
Keep disctinction between SignalLevel in coverage and coverage-map, this way coverage-map doesn't need to bring in sqlx as a dependency
rewards should never fail. but we can skip a radio and have an alert that says something went wrong.
Move zipping trust scores with their distances to heartbeatreward. Leave I put the use statements above where they are in the function because the names of the types kind of overlap with the names used in the mobile verifier, and I wanted to make it extra clear to anyone reading, this function is transforming those values into calculator types.
we can clone the speed_tests and trust_scores as they enter the calculator, but everything else can work with a reference for much longer.
The constructor no longer tries to calculate points, it collects information about radios and coverage. All the pointing happens in into_rewards.
This matches with the other reward structs `MapperShares`, `ServiceProviderShares`. And reflects more that we're talking about `reward_shares`, where `coverage_points` is starting to mean points provided towards shares relating only to coverage (excluding backhaul (speedtests)).
This all lives in the coverage-point-calculator now
We can insert coverage objects directly after iterating over them, radio_info only needs to know if the radio `is_indoor`. Moving that binding to the top helps hint that it's set by something in the block and returned. And we don't need to carry around covered_hexes for any longer than necessary.
bbalser
reviewed
Jun 14, 2024
bbalser
approved these changes
Jun 20, 2024
macpie
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoveragePointshas been renamed toCoverageRewards.CoverageRewards::aggregate_points()renamed toCoverageRewards::new().coverage-mapandcoverage-point-calculator. (-1,348 huzzah!)