Change coverage map to treat hotspot_key as bytes rather than a PublicKeyBinary #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maplant
reviewed
Jun 6, 2024
| CoverageObject { | ||
| indoor: false, | ||
| hotspot_key: owner, | ||
| hotspot_key: vec![0, 0], |
There was a problem hiding this comment.
it's not very important, but these don't even need to be length 2. They could just be vec![0], vec![1], etc.
maplant
approved these changes
Jun 6, 2024
coverage_map/Cargo.toml
Outdated
| @@ -10,7 +10,6 @@ edition.workspace = true | |||
| [dependencies] | |||
| chrono = { workspace = true } | |||
| h3o = { workspace = true } | |||
There was a problem hiding this comment.
h30, helium-proto, and uuid are also candidates for removal.
There was a problem hiding this comment.
nice catch!, removed 530cb59
michaeldjeffrey
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to keep this crate simple and the deps small, refactored to treat the hotspot_key as just a bag of bytes rather than a PublicKeyBinary.