Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create hex_assignments crate #817

Merged
merged 6 commits into from
May 30, 2024
Merged

Conversation

kurotych
Copy link
Member

@kurotych kurotych commented May 24, 2024

Motivation

Make it possible to reuse some parts of boosting Oracle code without bloated dependencies from mobile_verifier and the tided sqlx version.

Changes

  • Create hex_assignments crate
  • Add HexBoostDataAssignments trait to comfortable pass HexBoostData as argument without repeatable specifying template arguments
  • Remove the new_mock function instead use the optional parameter in new, since I wanna use it without "data set downloader" but the "_mock" postfix signaling that it is functional for "testing only" which is not.

@kurotych kurotych marked this pull request as ready for review May 24, 2024 11:49
Copy link
Contributor

@michaeldjeffrey michaeldjeffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get the Cargo.toml files auto-formatted to match everything?

@maplant maplant merged commit b3585cd into helium:main May 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants