Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile Config filter Boosted Hexes #801

Merged
merged 8 commits into from
May 8, 2024
Merged

Mobile Config filter Boosted Hexes #801

merged 8 commits into from
May 8, 2024

Commits on May 7, 2024

  1. Refactor to use BoostedHexes methods 

    Making the internal member hexes private will make it easier to change
the implementation when device type is introduced.
    @michaeldjeffrey
    michaeldjeffrey committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c896a82 View commit details
    Browse the repository at this point in the history

  2. Add device type to boosted hex info

    @michaeldjeffrey
    michaeldjeffrey committed May 7, 2024
    Configuration menu
    Copy the full SHA
    2b558ca View commit details
    Browse the repository at this point in the history

  3. refactor metadata_db tests to make test clearer 

    also makes it easier to add new tests
    @michaeldjeffrey
    michaeldjeffrey committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8091ceb View commit details
    Browse the repository at this point in the history

  4. remove expired boosted hexes when streaming from db

    @michaeldjeffrey
    michaeldjeffrey committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8767a15 View commit details
    Browse the repository at this point in the history

  5. ensure no tests are written with expired boosted hexes

    @michaeldjeffrey
    michaeldjeffrey committed May 7, 2024
    Configuration menu
    Copy the full SHA
    fb80d44 View commit details
    Browse the repository at this point in the history

  6. optimize by computing end_ts in db query 

    Thanks for the query help Brian!

By precomputing the end timestamp of a boosted hex, we can not have to
stream all the hexes out of the db just to throw them away.
    @michaeldjeffrey
    michaeldjeffrey committed May 7, 2024
    Configuration menu
    Copy the full SHA
    dde0707 View commit details
    Browse the repository at this point in the history

  7. fixup after rebase 

    - remove unused imports
- remove old refactor return types
    @michaeldjeffrey
    michaeldjeffrey committed May 7, 2024
    Configuration menu
    Copy the full SHA
    18fc99a View commit details
    Browse the repository at this point in the history

  8. make boosted hex test function more explicit 

    If the expired check had been made a global check, the ability to use
BoostedHexes for modified hexes would have broken at runtime.

The attempt here is to make very explicit during testing how to meet the
same contract as the database queries for boosted hexes. I think there
are still some cracks, but we can narrow in on those as we find them.
For now, I think naming test constructor functions is a good start.
    @michaeldjeffrey
    michaeldjeffrey committed May 7, 2024
    Configuration menu
    Copy the full SHA
    66b36d8 View commit details
    Browse the repository at this point in the history