Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wifi heartbeats originating from indoor wifi hotspots #623

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

andymck
Copy link
Contributor

@andymck andymck commented Aug 31, 2023

Provides support for the ingestion, processing & rewarding of wifi heartbeats

Linked proto pr: helium/proto#364

@andymck andymck force-pushed the andymck/wifi-heartbeats branch 2 times, most recently from b17e7aa to 0c66e99 Compare August 31, 2023 16:26
@andymck andymck changed the title Andymck/wifi heartbeats Support wifi heartbeats originating for indoor wifi hotspots Sep 1, 2023
@andymck andymck changed the title Support wifi heartbeats originating for indoor wifi hotspots Support wifi heartbeats originating from indoor wifi hotspots Sep 1, 2023
@andymck andymck force-pushed the andymck/wifi-heartbeats branch 3 times, most recently from fadd3b6 to 27bbd18 Compare September 5, 2023 15:18
@andymck andymck force-pushed the andymck/wifi-heartbeats branch 2 times, most recently from 1e48638 to bc575b4 Compare September 6, 2023 14:00
@andymck andymck marked this pull request as ready for review September 7, 2023 13:59
mobile_verifier/src/cell_type.rs Outdated Show resolved Hide resolved
mobile_verifier/src/heartbeats.rs Outdated Show resolved Hide resolved
mobile_verifier/src/heartbeats.rs Outdated Show resolved Hide resolved
mobile_verifier/src/heartbeats.rs Outdated Show resolved Hide resolved
mobile_verifier/src/heartbeats.rs Outdated Show resolved Hide resolved
mobile_verifier/src/heartbeats.rs Outdated Show resolved Hide resolved
mobile_verifier/src/heartbeats.rs Outdated Show resolved Hide resolved
mobile_verifier/src/lib.rs Show resolved Hide resolved
mobile_verifier/src/reward_shares.rs Outdated Show resolved Hide resolved
@andymck andymck force-pushed the andymck/wifi-heartbeats branch 2 times, most recently from df3fe4c to 994d0fe Compare September 20, 2023 14:26
Copy link
Contributor

@maplant maplant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming heartbeats to heartbeats_util and wifi_heartbeats seems like a pretty drastic and non-idiomatic change. If you'd like to split that file up, I recommend creating a heartbeats directory, putting the "util" contents into the mod.rs, and the wifi contents into wifi.rs module

@andymck
Copy link
Contributor Author

andymck commented Sep 25, 2023

Renaming heartbeats to heartbeats_util and wifi_heartbeats seems like a pretty drastic and non-idiomatic change. If you'd like to split that file up, I recommend creating a heartbeats directory, putting the "util" contents into the mod.rs, and the wifi contents into wifi.rs module

to clarify, heartbeats was broken up into 3 modules. cbrs_heartbeats, wifi_heartbeats and then a shared module heartbeats_util. I do like the approach of adding a heartbeats directory which then containts cbrs, wifi and then a mod.util and will change to that

@maplant
Copy link
Contributor

maplant commented Sep 25, 2023

Renaming heartbeats to heartbeats_util and wifi_heartbeats seems like a pretty drastic and non-idiomatic change. If you'd like to split that file up, I recommend creating a heartbeats directory, putting the "util" contents into the mod.rs, and the wifi contents into wifi.rs module

to clarify, heartbeats was broken up into 3 modules. cbrs_heartbeats, wifi_heartbeats and then a shared module heartbeats_util. I do like the approach of adding a heartbeats directory which then containts cbrs, wifi and then a mod.util and will change to that

Personally I would just name them cbrs.rs and wifi.rs, it's implied they're related to heartbeats by being in the heartbeats directory

Ah nevermind ^ I see that's what you did. Great!

file_store/src/cli/dump.rs Show resolved Hide resolved
file_store/src/heartbeat.rs Show resolved Hide resolved
mobile_verifier/src/cell_type.rs Outdated Show resolved Hide resolved
mobile_verifier/src/heartbeats/mod.rs Show resolved Hide resolved
@andymck andymck force-pushed the andymck/wifi-heartbeats branch 3 times, most recently from 3116752 to 60f2542 Compare October 2, 2023 12:45
@andymck andymck merged commit 26b07de into main Oct 2, 2023
1 check passed
@andymck andymck deleted the andymck/wifi-heartbeats branch October 2, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants