Modeled Coverage Phase 1 #619

maplant · 2023-08-28T15:44:10Z

No description provided.

mobile_verifier/src/coverage.rs

mobile_verifier/src/heartbeats.rs

Improve logs for conflicting hexes, add log for seniority insert Remove logs, update uuid as well

andymck

generally lgtm. I pointed out a few issues to be addressed when bringing Wifi into the mix but I didnt outline all issues...just those that stood out.

Plan to take another pass at things

mobile_verifier/src/coverage.rs

mobile_verifier/migrations/16_modeled_coverage.sql

mobile_verifier/src/reward_shares.rs

andymck

Needs a proto bump and clippy a lil unhappy, but other than that lgtm

mobile_verifier/src/heartbeats/mod.rs

Modeled coverage phase 1

1cfff2a

maplant requested review from andymck, bbalser and jeffgrunewald August 28, 2023 15:44

andymck reviewed Aug 29, 2023

View reviewed changes

mobile_verifier/src/coverage.rs Show resolved Hide resolved

mobile_verifier/src/coverage.rs Show resolved Hide resolved

mobile_verifier/src/coverage.rs Show resolved Hide resolved

mobile_verifier/src/heartbeats.rs Outdated Show resolved Hide resolved

maplant added 12 commits August 29, 2023 12:39

Address comments

aeb9e0a

Fmt

cc4d148

Merge remote-tracking branch 'origin/main' into map/mc-p1

45379ac

Fix error in test that snuck in somehow

c1015e7

Merge remote-tracking branch 'origin/main' into map/mc-p1

d9d0126

Add on conflict to hex_coverage insertion

7efabf0

Improve logs for conflicting hexes, add log for seniority insert Remove logs, update uuid as well

Check if hex_coverage is empty in coalesce

0a32b19

Remove duplicate hex coverage checks for testing

188aada

Move to invalidating previous coverage objects

73e7f85

Add is null check for invalidated_at in update

cf8edd7

Merge remote-tracking branch 'origin/main' into map/mc-p1

7e4afbb

Merge remote-tracking branch 'origin/main' into map/mc-p1

1ab933c

andymck reviewed Oct 31, 2023

View reviewed changes

maplant added 9 commits November 1, 2023 15:48

Fix up MC Phase 1 to handle wifi coverage objects

19b2cea

Make coverage objects optional for phase 1

8a724d4

Fix iot-beacon-report

c5d32b0

Merge remote-tracking branch 'origin/main' into map/mc-p1

6ae5347

Update to master

f7f0efb

Fix seniority updates

f23889c

make radio_type a postgres enum

504eddb

Fix insertion of coverage objects

04c233a

Add prefix

b88952d

andymck approved these changes Nov 7, 2023

View reviewed changes

mobile_verifier/src/heartbeats/mod.rs Show resolved Hide resolved

bbalser and others added 2 commits November 7, 2023 07:34

make clippy happy

5cc0ed4

Fix key column name

8359c45

maplant added 4 commits November 7, 2023 09:21

Merge branch 'map/mc-p1' of github.com:helium/oracles into map/mc-p1

1fdf088

s/fetch_one/execute/g

3cb54eb

Add test for seniority updates

33ee356

add more integration tests

2d62fdb

bbalser approved these changes Nov 7, 2023

View reviewed changes

maplant added 4 commits November 7, 2023 16:04

Don't use select star

632f19f

Expand modeled_coverage tests to include caches

488d62c

One more test

60044f5

Merge remote-tracking branch 'origin/main' into map/mc-p1

d31f9ef

maplant merged commit 54760df into main Nov 8, 2023
1 check passed

maplant deleted the map/mc-p1 branch November 8, 2023 16:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modeled Coverage Phase 1 #619

Modeled Coverage Phase 1 #619

maplant commented Aug 28, 2023

andymck left a comment

andymck left a comment

Modeled Coverage Phase 1 #619

Modeled Coverage Phase 1 #619

Conversation

maplant commented Aug 28, 2023

andymck left a comment

Choose a reason for hiding this comment

andymck left a comment

Choose a reason for hiding this comment