fix witness metadata on invalid reports #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffgrunewald
requested review from
andymck,
Vagabond,
bbalser and
JayKickliter
madninja
reviewed
Aug 26, 2023
bbalser
approved these changes
Aug 26, 2023
andymck
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the stage at the end of
do_witness_verificationsin the iot_verifier poc.rs module where we assign non-zero values to invalid witness metadata we should have validated the witness's on-chain metadata at least (the invalid witness report was invalid for a different reason) so we should assign the witnesses's metadata to its section of the invalid report rather than the beaconer's.