drop hardcoded sign key, replace with support for N keys via settings #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymck
force-pushed
the
andymck/denylist/support-n-sign-keys-from-settings
branch
from
f0c5fb8
to
9134d8a
Compare
madninja
reviewed
Aug 22, 2023
bbalser
approved these changes
Aug 22, 2023
andymck
force-pushed
the
andymck/denylist/support-n-sign-keys-from-settings
branch
from
a8b868b
to
deef0e6
Compare
madninja
reviewed
Aug 22, 2023
maplant
reviewed
Aug 22, 2023
madninja
reviewed
Aug 22, 2023
jeffgrunewald
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked ops PR: https://github.com/novalabsxyz/ops/pull/775
Replaces a single hardcoded sign key used to verify the signature of denylist updates with N keys defined via settings