enrich denied reports with denylist tagname #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbalser
approved these changes
Aug 17, 2023
jeffgrunewald
approved these changes
Aug 17, 2023
Comment on lines
471
to
479
| tracing::debug!( | ||
| "report verification failed, reason: {:?}. | ||
| pubkey: {}", | ||
| pubkey: {}, tagname: {}", | ||
| InvalidReason::Denied, | ||
| pub_key, | ||
| deny_list.tag_name | ||
| ); |
There was a problem hiding this comment.
tracing::debug!(pub_key, tagname = deny_list.tag_name, reason = ?InvalidReason::Denied, "report verification failed");
jeffgrunewald
approved these changes
Aug 17, 2023
bbalser
approved these changes
Aug 17, 2023
andymck
force-pushed
the
andymck/include-denylist-version
branch
from
8e3a728
to
54e9188
Compare
madninja
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked proto PR: helium/proto#366
The proto adds an invalid_details field to invalid witness and beacon reports and the verified witness report
Enables poc verifications to return additional context on why a report was declared invalid and for those details to be carried through to the protos hitting S3.
Currently the only poc verification check which is populating this field is the denylist check. If a report is found to be on the denylist
invalid_detailswill be set to the tagname of the list in useA tag name looks like
2023072901