Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define new custom regions #27

Merged
merged 8 commits into from
May 6, 2023
Merged

define new custom regions #27

merged 8 commits into from
May 6, 2023

Conversation

mikev
Copy link
Contributor

@mikev mikev commented Dec 20, 2022

Problem Statement:
Often a country or several countries need a custom region, which defines slightly different parameters. For example in Malaysia any frequencies in 924 Mhz are not legal.

Solution:
So we defined a new region AS923_1B which did not use frequency within 924 Mhz. Now Kenya needs this same custom region, because some of our EU868 frequencies are not legal. This will be a recurring pattern. The PR, review, commit process is painful so lets just do this once across all our repos and define EU868_A to _F and AS923_1A .. 1F

Only AS923 and EU868 will require custom regions.

Other changes

AU915_DP is removed. This frequency plan was aligned to Louis original DualPlan proposal. However it defines a plan which straddles both SB5 and SB6. It is unclear if this would work for all sensor device configurations.

Libraries (Require a review 1st)
helium/proto#250
helium/blockchain-core#1502
#27

Projects
helium/miner#1873
https://github.com/helium/gateway-rs/search?q=as923 [gateway-rs no longer requires enum]
helium/sx1302_hal#36
https://github.com/helium/docs/pull/1048/files
helium/helium-config-service#27 (edited)

@mikev mikev self-assigned this Dec 20, 2022
@mikev mikev requested a review from ke6jjj December 22, 2022 20:44
@ke6jjj
Copy link

ke6jjj commented Jan 3, 2023

@mikev, is it intentional/ok that the other PRs enumerate EU868_A-F but this code only seems to instantiate EU868_B?

@mikev
Copy link
Contributor Author

mikev commented Jan 4, 2023

@ke6jjj - Yes it is intentional. EU868A-F are placeholders and not needed currently.

@mikev mikev requested a review from michaeldjeffrey May 2, 2023 01:03
src/lora_chmask.erl Outdated Show resolved Hide resolved
case IsAU915DP of
true -> 'AU915_DP';
'AS923_1C' ->
IsAU915_1C = find_frequency(Freq, SB5_List),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't tell if something in here is a typo.

AS923_1 clause is checking for Subband 2 in SB5_List and returning AU915_SB5.
AS293_1C clause is checking for AU 1C in SB5_List and also returning AU915_SB5.

Of which region is SB5_List referring to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both should be the exact same logic.

They are both checking for any of the 6 frequencies of 8 in sub-band 5. They exclude the 2 Join frequencies from AS923.
If any of those frequencies are found the SB5 region is returned to the caller.

@mikev mikev merged commit 3a18455 into master May 6, 2023
@mikev mikev deleted the mv/customregions branch May 6, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants