-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
define new custom regions #27
Conversation
@mikev, is it intentional/ok that the other PRs enumerate |
@ke6jjj - Yes it is intentional. EU868A-F are placeholders and not needed currently. |
case IsAU915DP of | ||
true -> 'AU915_DP'; | ||
'AS923_1C' -> | ||
IsAU915_1C = find_frequency(Freq, SB5_List), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't tell if something in here is a typo.
AS923_1
clause is checking for Subband 2 in SB5_List
and returning AU915_SB5
.
AS293_1C
clause is checking for AU 1C in SB5_List
and also returning AU915_SB5
.
Of which region is SB5_List
referring to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both should be the exact same logic.
They are both checking for any of the 6 frequencies of 8 in sub-band 5. They exclude the 2 Join frequencies from AS923.
If any of those frequencies are found the SB5 region is returned to the caller.
Problem Statement:
Often a country or several countries need a custom region, which defines slightly different parameters. For example in Malaysia any frequencies in 924 Mhz are not legal.
Solution:
So we defined a new region AS923_1B which did not use frequency within 924 Mhz. Now Kenya needs this same custom region, because some of our EU868 frequencies are not legal. This will be a recurring pattern. The PR, review, commit process is painful so lets just do this once across all our repos and define EU868_A to _F and AS923_1A .. 1F
Only AS923 and EU868 will require custom regions.
Other changes
AU915_DP is removed. This frequency plan was aligned to Louis original DualPlan proposal. However it defines a plan which straddles both SB5 and SB6. It is unclear if this would work for all sensor device configurations.
Libraries (Require a review 1st)
helium/proto#250
helium/blockchain-core#1502
#27
Projects
helium/miner#1873
https://github.com/helium/gateway-rs/search?q=as923 [gateway-rs no longer requires enum]
helium/sx1302_hal#36
https://github.com/helium/docs/pull/1048/files
helium/helium-config-service#27 (edited)