This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
refine receipt validation test #1362
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffgrunewald
force-pushed
the
jg/skip_receipt_val_var
branch
from
273d9db
to
e84cea3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refine the common tests that assert when validation of receipts_v2 during witnesses is both enabled and disabled via the chain variable
poc_receipt_witness_validation.This new version of the test asserts that when validation is enabled, one witness successfully passes validation while the other witness fails (with an invalid frequency for its asserted region). When the validation is disabled in the other test, both witnesses are successfully counted as "valid".