fix: check for all changes when adding summary

heliosphere-xiv · Oct 24, 2023 · dace44e · dace44e
1 parent 98fdd6e
commit dace44e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/DownloadTask.cs b/DownloadTask.cs
@@ -1043,7 +1043,7 @@ private async Task ConstructGroups(IDownloadTask_GetVersion info) {
                 }
             }
 
-            if (change.RemovedGroups.Count > 0) {
+            if (change.HasChanges) {
                 using var handle = await this.Plugin.PluginUi.BreakingChangeWindow.BreakingChanges.WaitAsync();
                 handle.Data.Add(change);
             }
@@ -1282,4 +1282,4 @@ public override long Position {
         get => this._inner.Position;
         set => this._inner.Position = value;
     }
-}
+}
diff --git a/Ui/BreakingChangeWindow.cs b/Ui/BreakingChangeWindow.cs
@@ -156,4 +156,10 @@ internal class BreakingChange {
     internal List<(string Group, string[] RemovedOptions)> TruncatedOptions { get; } = new();
     internal List<(string Group, string[] Old, string[] New)> DifferentOptionNames { get; } = new();
     internal List<(string Group, string[] Old, string[] New)> ChangedOptionOrder { get; } = new();
-}
+
+    internal bool HasChanges => this.RemovedGroups.Count > 0
+                                || this.ChangedType.Count > 0
+                                || this.TruncatedOptions.Count > 0
+                                || this.DifferentOptionNames.Count > 0
+                                || this.ChangedOptionOrder.Count > 0;
+}