refactor: silence some warnings

heliosphere-xiv · Mar 11, 2024 · 04ef6b0 · 04ef6b0
1 parent 797e2cd
commit 04ef6b0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/DownloadTask.cs b/DownloadTask.cs
@@ -945,6 +945,11 @@ private async Task ConstructGroups(IDownloadTask_GetVersion info) {
             try {
                 var text = await FileHelper.ReadAllTextAsync(existing);
                 var group = JsonConvert.DeserializeObject<ModGroup>(text);
+                if (group == null) {
+                    Plugin.Log.Warning("Could not deserialise old group (was null)");
+                    continue;
+                }
+
                 oldGroups.Add(group);
             } catch (Exception ex) {
                 Plugin.Log.Warning(ex, "Could not deserialise old group");

diff --git a/Util/DependencyHelper.cs b/Util/DependencyHelper.cs
@@ -45,6 +45,8 @@ internal static async Task<bool> CheckDependencies(Plugin plugin) {
     }
 }
 
+#pragma warning disable CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider declaring as nullable.
+
 [Serializable]
 [JsonObject(NamingStrategyType = typeof(CamelCaseNamingStrategy))]
 internal class DependencyInfo {