Commits on Jul 9, 2019

1. Fix compiler warnings …

   ~~~
   Compiling 1 file (.ex)
   warning: variable "opts" is unused (if the variable is not meant to be used, prefix it with an underscore)
     lib/hedwig_xmpp.ex:109: Hedwig.Adapters.XMPP.handle_info/2
   
   warning: variable "ns_muc_user" does not exist and is being expanded to "ns_muc_user()", please use parentheses to remove the ambiguity or change the variable name
     lib/hedwig_xmpp.ex:151: Hedwig.Adapters.XMPP.contains_muc_user_namespace?/1
   
   warning: variable "self" does not exist and is being expanded to "self()", please use parentheses to remove the ambiguity or change the variable name
     lib/hedwig_xmpp.ex:161: Hedwig.Adapters.XMPP.get_roster/2
   
   warning: variable "self" does not exist and is being expanded to "self()", please use parentheses to remove the ambiguity or change the variable name
     lib/hedwig_xmpp.ex:184: Hedwig.Adapters.XMPP.request_all_rooms/2
   ~~~

   

   msantos committed Jul 9, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 7abb133
   • Browse repository at this point

   Copy the full SHA

   7abb133 View commit details

   Browse the repository at this point in the history

2. Fix crash in presence handling …

   An "x" element without an item field will cause the bot to crash:
   
   ~~~
   ** (FunctionClauseError) no function clause matching in
   :fxml.get_subtag/2
       (fast_xml)
   fxml.erl:175:
   :fxml.get_subtag(nil, "item")
       (romeo) lib/romeo/xml.ex:45: Romeo.XML.subelement/3
       (hedwig_xmpp) lib/hedwig_xmpp.ex:142:
   Hedwig.Adapters.XMPP.real_jid_from_room_presence/1
   ~~~
   
   For example, if a group chat contains a vcard for an avatar:
   
   ~~~
   {:xmlel, "presence", [{"to", "dest"}, {"from", "source@muc"}, {"id", "1234"}],
    [
      {:xmlel, "x", [{"xmlns", "vcard-temp:x:update"}],
       [{:xmlel, "photo", [], [xmlcdata: "5678"]}]},
      {:xmlel, "c",
       [
         {"xmlns", "http://jabber.org/protocol/caps"},
         {"ver", "jiZ985RsHMpIJvoWKUczSnQ5MSs="},
         {"node", "http://www.process-one.net/en/ejabberd/"},
         {"hash", "sha-1"}
       ], []}
    ]}
   ~~~

   

   msantos committed Jul 9, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for bb97e1f
   • Browse repository at this point

   Copy the full SHA

   bb97e1f View commit details

   Browse the repository at this point in the history