Add parallel' and sequential' that take a generator of commands #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More general than the unticked version that only takes a list and uses `Gen.element` to choose one.
|
Does this have a chance of being merged? |
|
This looks like a good addition to me. Hopefully we can get it in in some form (but I'm not a maintainer, so I won't be able to help there). |
|
I meant to comment about this earlier sorry. I don't think there's anything really wrong with this, but, I feel we should fixup At the moment, the docs for As there's a hacky solution, I feel there's probably a good solution for both of these. |
jacobstanley
force-pushed
the
master
branch
2 times, most recently
from
4139585
to
c228279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More general than the unticked version that only takes a list and uses
Gen.elementto choose one.This allows you to, for example, use
Gen.frequencyto generate commands with different weights.