Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [ISSUE-68] send_multicast method causes HTTP 404 response #69

Merged
merged 1 commit into from
Jan 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 3.4.1
* [FIX] The batch URL is composed incorrectly, which causes an HTTP 404 response to be received.

## 3.4.0
* Refactored ``async_firebase.base.AsyncClientBase`` to take advantage of connection pool. So the HTTP client will be created once during class ``async_firebase.client.AsyncFirebaseClient`` instantiation.

Expand Down
2 changes: 1 addition & 1 deletion async_firebase/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ async def send_request(
:param content: request content
:return: HTTP response
"""
url = join_url(self.BASE_URL, self.FCM_ENDPOINT.format(project_id=self._credentials.project_id), uri)
url = join_url(self.BASE_URL, uri)
logging.debug(
"Requesting POST %s, payload: %s, content: %s, headers: %s",
url,
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "async-firebase"
version = "3.4.0"
version = "3.4.1"
description = "Async Firebase Client - a Python asyncio client to interact with Firebase Cloud Messaging in an easy way."
license = "MIT"
authors = [
Expand Down
Loading