Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testing of min and optional requirements #99

Merged
merged 19 commits into from
Jul 12, 2023
Merged

Fix testing of min and optional requirements #99

merged 19 commits into from
Jul 12, 2023

Conversation

rly
Copy link
Contributor

@rly rly commented Jun 18, 2023

Motivation

See hdmf-dev/hdmf#876
Fixes the analogous issue here.

How to test the behavior?

Run tests

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.05 ⚠️

Comparison is base (6a3474e) 81.99% compared to head (d04210d) 81.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #99      +/-   ##
==========================================
- Coverage   81.99%   81.94%   -0.05%     
==========================================
  Files          11       11              
  Lines        2660     2664       +4     
==========================================
+ Hits         2181     2183       +2     
- Misses        479      481       +2     
Impacted Files Coverage Δ
test_gallery.py 30.26% <50.00%> (+1.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rly rly marked this pull request as ready for review June 18, 2023 08:33
@rly rly requested a review from oruebel July 1, 2023 08:33
@oruebel oruebel merged commit 30219ba into dev Jul 12, 2023
21 checks passed
@oruebel oruebel deleted the rly-patch-1 branch July 12, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants