Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support python 3.12 #172

Merged
merged 18 commits into from
Mar 11, 2024
Merged

Update to support python 3.12 #172

merged 18 commits into from
Mar 11, 2024

Conversation

mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented Mar 3, 2024

Motivation

What was the reasoning behind this change? Please explain the changes briefly.
Support python 3.12

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@mavaylon1 mavaylon1 self-assigned this Mar 3, 2024
@mavaylon1 mavaylon1 added category: enhancement improvements of code or code behavior priority: high impacts proper operation or use of feature important to most users labels Mar 3, 2024
@mavaylon1 mavaylon1 added this to the Next Release milestone Mar 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.04%. Comparing base (556ed12) to head (bda8bf3).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #172   +/-   ##
=======================================
  Coverage   86.04%   86.04%           
=======================================
  Files           5        5           
  Lines        1161     1161           
  Branches      296      288    -8     
=======================================
  Hits          999      999           
  Misses        107      107           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1
Copy link
Contributor Author

Note: After updating the .toml, tox, and workflows, I did a search for "3.11". I'll do another look to see what else needs to be bumped to 3.12

@mavaylon1
Copy link
Contributor Author

mavaylon1 commented Mar 3, 2024

@oruebel The bump to 3.12 seems to have bequeathed some gallery errors that need to be resolved. I'd like to make it a separate ticket/PR to not hold this up. Thoughts? I need to do another pass through before requesting a review.

Update: I just ended up fixing it here. A new warning filter for test_gallery.py

@mavaylon1
Copy link
Contributor Author

Review Note: I did not update the changelog since this is not a user facing update.

@mavaylon1 mavaylon1 requested a review from rly March 11, 2024 14:58
@mavaylon1 mavaylon1 marked this pull request as ready for review March 11, 2024 14:58
@rly
Copy link
Contributor

rly commented Mar 11, 2024

Review Note: I did not update the changelog since this is not a user facing update.

Please add a changelog -- The changelog is for any change to the software, and is for both users and developers, especially to check for changes that affect compatibility (here, for example, we announce that PyNWB is officially compatible with Python 3.12 - some downstream packages do not support Python 3.12 because pynwb does not so it's important for us to announce this).

In contrast, when making changes to the schema repo, the schema release notes should not be updated when there are no changes to the schema files. We could add a changelog there for all changes to the repo, but its not really necessary because the main purpose of the schema repo is to hold the schema files. The surrounding code is for internal use.

@rly
Copy link
Contributor

rly commented Mar 11, 2024

I mean HDMF-Zarr, not PyNWB, though my example about downstream packages not supporting a version of Python because PyNWB does not officially support is is true for PyNWB, not HDMF-Zarr (AFAIK)

@mavaylon1
Copy link
Contributor Author

I mean HDMF-Zarr, not PyNWB, though my example about downstream packages not supporting a version of Python because PyNWB does not officially support is is true for PyNWB, not HDMF-Zarr (AFAIK)

Got it. Done.

@mavaylon1 mavaylon1 merged commit 897d3b9 into dev Mar 11, 2024
24 checks passed
@mavaylon1 mavaylon1 deleted the py312 branch March 11, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: high impacts proper operation or use of feature important to most users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants