Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows #129

Closed
wants to merge 3 commits into from
Closed

Workflows #129

wants to merge 3 commits into from

Conversation

mavaylon1
Copy link
Contributor

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

Add workflows that exist in HDMF: ruff (to replace flake8) and codespell.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Run the workflows

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9f6c386) 85.66% compared to head (f68d999) 85.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #129   +/-   ##
=======================================
  Coverage   85.66%   85.66%           
=======================================
  Files          13       13           
  Lines        3139     3139           
=======================================
  Hits         2689     2689           
  Misses        450      450           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1
Copy link
Contributor Author

@rly @oruebel I'm adding these workflows and I suppose a larger question is coming up: "Should this PR also include the shift from setup.py to pyproject.toml/remove versioneer to how hdmf handles versions with hatch". I ask this because flake8 is setup through the .cfg and HDMF replaced flake8 with ruff (which is handled in the pyproject.toml). I'm thinking that this PR can be:

  1. Bring the workflows up to HDMF
  2. switch to pyproject.toml
  3. Switch version control to hatch
    The only thing that this would wait for is the fix to the release bug I showed @rly on Friday that creates a wheel with the wrong version. Once that fix is in HDMF, that can also be included here. I think this can be done this week depending on the release bug. I also created a ticket for the bug: [Bug]: Wrong Version when creating a release hdmf#956

@mavaylon1
Copy link
Contributor Author

This PR is not ready for review, nor have I finished supporting these new workflows.

@rly
Copy link
Contributor

rly commented Oct 3, 2023

Yes, let's do a full update so that the testing and maintenance infrastructure is the same as in hdmf.

@mavaylon1 mavaylon1 closed this Nov 27, 2023
@mavaylon1 mavaylon1 deleted the workflows branch April 11, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants