Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prefixed internal Strapi ID as rpbId and support duplicate / clone functionality in list view #47

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

fsteeg
Copy link
Member

@fsteeg fsteeg commented Sep 17, 2024

For articles and independent-works. Problem was the non-editable,
non-unique `rpbId` in the clone, which failed to validate. Fixed:

- Set `rpbId` to `"unique": false` (but still non-editable)
- Set `rpbId` to prefixed internal Strapi ID in `afterCreate` hook
(like in RPB-194 for new entries that have no `rpbId`, but
additionally if there are multiple entries with the same `rpbId`,
i.e. we created a clone)
@fsteeg fsteeg changed the title Use prefixed internal Strapi ID as rpbId (RPB-194) Use prefixed internal Strapi ID as rpbId and support duplicate / clone functionality in list view Sep 27, 2024
@fsteeg fsteeg marked this pull request as ready for review September 27, 2024 13:47
@fsteeg fsteeg requested a review from acka47 September 27, 2024 13:47
Copy link
Contributor

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Did functional review.

  • Copying of independent work and article works.
  • s and a IDs are used both when creating new entries or copying.

@fsteeg fsteeg assigned fsteeg and unassigned acka47 Sep 30, 2024
@fsteeg fsteeg merged commit f807e08 into main Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants