-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to identify RPB ZSS in ALMA #42
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
build.sbt
Outdated
@@ -17,7 +17,7 @@ libraryDependencies ++= Seq( | |||
"org.metafacture" % "metafacture-flux" % "5.7.0-rc1", | |||
"org.metafacture" % "metafacture-triples" % "5.7.0-rc1", | |||
"org.metafacture" % "metafacture-formatting" % "5.7.0-rc1", | |||
"org.metafacture" % "metafix" % "0.6.0-rc3", | |||
"org.metafacture" % "metafix" % "0.6.0-SNAPSHOT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This causes the build to fail.
@TobiasNx Did you need something specific in the SNAPSHOT, or was this just to make it work for you locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, it was just to make it work locally. The new release should be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I'll revert to 0.6.0-rc3
for now, which is configured in the GitHub CI action.
Assigning @acka47, since you have been working on the reconciliation in OpenRefine. Now that the build passes you can merge this if that makes sense to you (not quite sure about the state of this since it's a draft). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acka47 the fix does not exclude DE-36 anymore.
@fsteeg should I merge this, or do you do it? |
I think this should contain some documentation about what this is (there is no issue linked and no description provided here), maybe in the README? In particular where the input file comes from and how we are using the output. |
No description provided.