-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1864-database #2053
1864-database #2053
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I dont know why the build does not fail, it should since I have not added Database as type to the schema yet. https://github.com/hbz/lobid-resources/actions/runs/10387357128/job/28760660701#step:8:68 @acka47 any idea? |
I assume #2052 was not set up so that a failed ajv actually makes the build fail but it only added the script to the pipeline which runs the ajv test. Someone document a way to make this work with ajv and GitHub actions at https://junghyeonsu.com/en/posts/using-ajv-and-github-actions-to-ensure-consistent-meta-information-across-json-files/#integrate-ajv-with-github-actions-for-automated-validation but I am not sure what we can transfer to our use case... |
@Phu2 gave the hint to add an exit command to |
Add mapping for type vivo:Database See #1864