Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1864-database #2053

Merged
merged 6 commits into from
Aug 15, 2024
Merged

1864-database #2053

merged 6 commits into from
Aug 15, 2024

Conversation

TobiasNx
Copy link
Contributor

Add mapping for type vivo:Database See #1864

Copy link
Contributor

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@TobiasNx
Copy link
Contributor Author

I dont know why the build does not fail, it should since I have not added Database as type to the schema yet.

https://github.com/hbz/lobid-resources/actions/runs/10387357128/job/28760660701#step:8:68

@acka47 any idea?

@acka47
Copy link
Contributor

acka47 commented Aug 15, 2024

I assume #2052 was not set up so that a failed ajv actually makes the build fail but it only added the script to the pipeline which runs the ajv test. Someone document a way to make this work with ajv and GitHub actions at https://junghyeonsu.com/en/posts/using-ajv-and-github-actions-to-ensure-consistent-meta-information-across-json-files/#integrate-ajv-with-github-actions-for-automated-validation but I am not sure what we can transfer to our use case...

@TobiasNx
Copy link
Contributor Author

@Phu2 gave the hint to add an exit command to src/test/resources/validateJsonTestFiles.sh Did that straight to master. Now the validation should fail and I can fix the schema.

@TobiasNx TobiasNx merged commit fa71b7f into master Aug 15, 2024
1 check passed
@TobiasNx TobiasNx deleted the 1864-database branch August 15, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants