-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt lobid-gnd UI for RPPD (RPB-38) #361
Draft
fsteeg
wants to merge
76
commits into
master
Choose a base branch
from
rppd
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `rpb`, branch `WIP-rpb-102`: Configure rppd-to-strapi.flux for prod data (see comments); `sbt "runMain rpb.ETL conf/rppd-to-strapi.flux"` `sbt "runMain rpb.ETL conf/rppd-to-lobid.flux"` Here, in `lobid-gnd`, branch `rppd`: `sbt "runMain apps.Index baseline"` `sbt run`
Fixes JSON links for current faulty IDs on missing gndIdentifier
Link to GND URI if GND is used as source, to RPPD if RPPD is used
Noticed while working on RPB-157
For autocomplete format: https://lobid.org/gnd/api#auto-complete, e.g. `format=json:preferredName,*_dateOfBirth+in_placeOfBirth`
Use `; ` for plain fields and templates; `, ` is often used in values, see test example: `Weizenbaum, Josef; Weizenbaum, J.`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://jira.hbz-nrw.de/browse/RPB-38.