Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors on MSYS platform #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

carlzhc
Copy link

@carlzhc carlzhc commented Jan 16, 2024

# make sure the required packages are already installed
$ pacman -Q | egrep '^(libbsd|ncurses|cmake)'
cmake 3.26.2-1
libbsd 0.11.7-1
ncurses 6.4-1
ncurses-devel 6.4-1

$ cd build && cmake .. && make VERBOSE=1

... ... (see the attached log file)
build.1712669255.log

@hboetes
Copy link
Owner

hboetes commented Apr 8, 2024

Thanks for your contribution. Can you show me a log with the current state of the PR?

@carlzhc
Copy link
Author

carlzhc commented Apr 9, 2024

Squashed the commits and updated the log.

@hboetes
Copy link
Owner

hboetes commented Apr 9, 2024

Thanks! I know it's working already, but wouldn't it be nice if those implicit declaration of function warnings were gone? There's probably a missing include or two in one of the header files.

@carlzhc
Copy link
Author

carlzhc commented Apr 9, 2024

Fixed those implicit declaration of function warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants