-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java clients v2 #1289
base: v/5.5
Are you sure you want to change the base?
Java clients v2 #1289
Conversation
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Minor changes from review pushed up, will continue working thru the page as there was some later sections I didn't get to edit yet |
Co-authored-by: ihsan demir <[email protected]>
@@ -1,19 +1,58 @@ | |||
= Java Client | |||
:page-api-reference: https://docs.hazelcast.org/docs/{page-latest-supported-java-client}/javadoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also have the link to java client javadoc at here as well.
* https://docs.hazelcast.org/hazelcast-java-client/{page-latest-supported-java-client-new}/javadoc[Hazelcast {java-client-new} API documentation]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a page variable that triggers the dropdown below the main heading, the page H1 - AFAIK we can't have two links here. i.e. this is a limitation of the existing one page structure. We can have references within the content though (see links further down), which I think is ok for Beta.
Latest changes pushed up - please review @alexey-agapov-hazelcast You can also see some comments in source where quick check would be appreciated: |
1st pass at merging content from different PRs into a clean PR - still needs further review and work but important notes:
Preview link: https://deploy-preview-1289--hardcore-allen-f5257d.netlify.app/hazelcast/5.5/clients/java