Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java clients v2 #1289

Open
wants to merge 11 commits into
base: v/5.5
Choose a base branch
from
Open

Conversation

oliverhowell
Copy link
Contributor

@oliverhowell oliverhowell commented Sep 13, 2024

1st pass at merging content from different PRs into a clean PR - still needs further review and work but important notes:

  • see // comments inline for questions and TBC
  • WIP restructure of Java client page
  • Contains latest cluster routing content TBC re: standalone
  • Variables move to antora file
  • WIP switch to Google Style Guide

Preview link: https://deploy-preview-1289--hardcore-allen-f5257d.netlify.app/hazelcast/5.5/clients/java

Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for hardcore-allen-f5257d ready!

Name Link
🔨 Latest commit b6bfd15
🔍 Latest deploy log https://app.netlify.com/sites/hardcore-allen-f5257d/deploys/66eab975d3e16c0008257b90
😎 Deploy Preview https://deploy-preview-1289--hardcore-allen-f5257d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/modules/clients/pages/java.adoc Outdated Show resolved Hide resolved
docs/modules/clients/pages/java.adoc Outdated Show resolved Hide resolved
docs/modules/clients/pages/java.adoc Outdated Show resolved Hide resolved
docs/modules/clients/pages/java.adoc Outdated Show resolved Hide resolved
docs/modules/clients/pages/java.adoc Outdated Show resolved Hide resolved
docs/modules/clients/pages/java.adoc Outdated Show resolved Hide resolved
@oliverhowell
Copy link
Contributor Author

Minor changes from review pushed up, will continue working thru the page as there was some later sections I didn't get to edit yet

docs/modules/clients/pages/java.adoc Outdated Show resolved Hide resolved
docs/modules/clients/pages/java.adoc Outdated Show resolved Hide resolved
docs/modules/clients/pages/java.adoc Outdated Show resolved Hide resolved
docs/modules/clients/pages/java.adoc Outdated Show resolved Hide resolved
docs/modules/clients/pages/java.adoc Outdated Show resolved Hide resolved
@oliverhowell oliverhowell marked this pull request as ready for review September 16, 2024 16:57
@@ -1,19 +1,58 @@
= Java Client
:page-api-reference: https://docs.hazelcast.org/docs/{page-latest-supported-java-client}/javadoc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also have the link to java client javadoc at here as well.

* https://docs.hazelcast.org/hazelcast-java-client/{page-latest-supported-java-client-new}/javadoc[Hazelcast {java-client-new} API documentation]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a page variable that triggers the dropdown below the main heading, the page H1 - AFAIK we can't have two links here. i.e. this is a limitation of the existing one page structure. We can have references within the content though (see links further down), which I think is ok for Beta.

@oliverhowell
Copy link
Contributor Author

Latest changes pushed up - please review @alexey-agapov-hazelcast

You can also see some comments in source where quick check would be appreciated:
// check standalone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants