Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debezium 2.x docs #1149

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

TomaszGaweda
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for hardcore-allen-f5257d ready!

Name Link
🔨 Latest commit e7c65e7
🔍 Latest deploy log https://app.netlify.com/sites/hardcore-allen-f5257d/deploys/66edae382e5fee00080fe0cf
😎 Deploy Preview https://deploy-preview-1149--hardcore-allen-f5257d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TomaszGaweda TomaszGaweda changed the title Add Debezium 2.x docs Add Debezium 2.x docs [WIP] Jun 27, 2024
@TomaszGaweda TomaszGaweda changed the title Add Debezium 2.x docs [WIP] Add Debezium 2.x docs Jun 28, 2024
Copy link
Contributor

@rebekah-lawrence rebekah-lawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this; most of the comments are just to change text to the new product variables.

Let me know if I have misunderstood or misrepresented anything in my suggestions and we can discuss.

@@ -1,4 +1,4 @@
= CDC Connector
= Legacy CDC Connector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
= Legacy CDC Connector
= {open-source-product-name} CDC Connector

@@ -0,0 +1,165 @@
= CDC Connector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
= CDC Connector
= {enterprise-product-name} CDC Connector

for the _streaming of changes from databases_, which can be efficiently
processed by the Jet engine.

Implementation of CDC in Hazelcast Enterprise is based on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Implementation of CDC in Hazelcast Enterprise is based on
Implementation of CDC in Hazelcast {enterprise-product-name} is based on

processed by the Jet engine.

Implementation of CDC in Hazelcast Enterprise is based on
link:https://debezium.io/[Debezium 2.x]. Hazelcast offers a generic Debezium source
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link:https://debezium.io/[Debezium 2.x]. Hazelcast offers a generic Debezium source
link:https://debezium.io/[Debezium 2.x]. Hazelcast offers a generic Debezium source,


Implementation of CDC in Hazelcast Enterprise is based on
link:https://debezium.io/[Debezium 2.x]. Hazelcast offers a generic Debezium source
which can handle CDC events from link:https://debezium.io/documentation/reference/2.7/connectors/index.html[any database supported by Debezium],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
which can handle CDC events from link:https://debezium.io/documentation/reference/2.7/connectors/index.html[any database supported by Debezium],
which can handle CDC events from link:https://debezium.io/documentation/reference/2.7/connectors/index.html[any database supported by Debezium, window=_blank].

docs/modules/integrate/pages/cdc-connectors.adoc Outdated Show resolved Hide resolved
docs/modules/integrate/pages/connectors.adoc Outdated Show resolved Hide resolved
docs/modules/integrate/pages/connectors.adoc Outdated Show resolved Hide resolved
docs/modules/pipelines/pages/cdc.adoc Outdated Show resolved Hide resolved
TomaszGaweda and others added 6 commits July 8, 2024 21:54
Co-authored-by: rebekah-lawrence <[email protected]>
Co-authored-by: rebekah-lawrence <[email protected]>
# Conflicts:
#	docs/modules/integrate/partials/nav.adoc
#	docs/modules/pipelines/pages/cdc.adoc
Copy link
Contributor

@rebekah-lawrence rebekah-lawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Not sure if you know @TomaszGaweda, but this is my final week at Hazelcast - I'm approving as all looks good - but just shout if you make further changes and want me to look again before Friday.

Thank you - fantastic work as a single-person team on this!

@oliverhowell oliverhowell added the backport to 5.5 Backport commits from main to v/5.5 label Jul 29, 2024
@oliverhowell
Copy link
Contributor

Note: don't merge yet!
Let me know when make sense @TomaszGaweda

Copy link
Contributor

@oliverhowell oliverhowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have left some minor comments and suggestions from a quick review - hope this helps!

docs/modules/integrate/pages/cdc-connectors.adoc Outdated Show resolved Hide resolved
docs/modules/integrate/pages/cdc-connectors.adoc Outdated Show resolved Hide resolved
docs/modules/integrate/pages/cdc-connectors.adoc Outdated Show resolved Hide resolved
docs/modules/integrate/pages/cdc-connectors.adoc Outdated Show resolved Hide resolved
docs/modules/integrate/pages/cdc-connectors.adoc Outdated Show resolved Hide resolved
docs/modules/integrate/pages/legacy-cdc-connectors.adoc Outdated Show resolved Hide resolved
docs/modules/integrate/pages/legacy-cdc-connectors.adoc Outdated Show resolved Hide resolved
docs/modules/integrate/pages/legacy-cdc-connectors.adoc Outdated Show resolved Hide resolved
docs/modules/integrate/pages/legacy-cdc-connectors.adoc Outdated Show resolved Hide resolved
docs/modules/integrate/pages/legacy-cdc-connectors.adoc Outdated Show resolved Hide resolved
TomaszGaweda and others added 2 commits September 5, 2024 18:44
Co-authored-by: Oliver Howell <[email protected]>
@TomaszGaweda
Copy link
Contributor Author

Thanks for great suggestions @oliverhowell! I've applied basically all of them + addressed migration guide vs tips

@oliverhowell
Copy link
Contributor

Thanks for great suggestions @oliverhowell! I've applied basically all of them + addressed migration guide vs tips

Thanks @TomaszGaweda - one final suggestion then (and one that is still unresolved).
I'll approve and leave for you to merge when timing is best (or let me know if you want me to merge at certain point).

@TomaszGaweda
Copy link
Contributor Author

@oliverhowell We can merge this PR if recent changes are ok with you.

Is backport process automated like in hazelcast-mono or manual?

@oliverhowell
Copy link
Contributor

@oliverhowell We can merge this PR if recent changes are ok with you.

Is backport process automated like in hazelcast-mono or manual?

Not had a chance to review your latest changes yet - when do you need it merged by?
For backports we add the labels to the PR - what versions are we backporting to?

@TomaszGaweda
Copy link
Contributor Author

@oliverhowell Would be great to merge it next week, as 5.5.2 should be released after DevDays. No worries, no hurry, I just want to make sure everything is there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to 5.5 Backport commits from main to v/5.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants