New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update `#!/usr/bin/env bash` references to `#!/bin/bash` [DI-216] #235

Closed

JackPGreen wants to merge 1 commit into master from Update-usr/bin/env-bash-references-to-bin/bash

Collaborator

JackPGreen commented Sep 3, 2024 •

edited by jira bot

Loading

We mostly use #!/bin/bash (~700 references), but sometimes we use #!/usr/bin/env bash (~500 references).

We should be consistent.

Of note - Google's style guide suggests the same.

Fixes: DI-216


          Update #!/usr/bin/env bash references to #!/bin/bash [DI-216]

27ef055

We _mostly_ use `#!/bin/bash` ([~700 references](https://github.com/search?q=org%3Ahazelcast+%22%23%21%2Fbin%2Fbash%22&type=code)), but sometimes we use `#!/usr/bin/env bash` ([~500 references](https://github.com/search?q=org%3Ahazelcast+%22%23%21%2Fusr%2Fbin%2Fenv+bash%22&type=code)).

We should be consistent.

Of note - [Google's style guide](https://google.github.io/styleguide/shellguide.html) suggests the same.

Fixes: [DI-216](https://hazelcast.atlassian.net/browse/DI-216)

JackPGreen requested a review from nishaatr

September 3, 2024 16:03

JackPGreen self-assigned this

JackPGreen enabled auto-merge (squash)

September 3, 2024 16:03

JackPGreen closed this

auto-merge was automatically disabled

September 4, 2024 10:39

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet