Stop referencing snapshots in Brew conflicts-with [DI-238]
#222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackPGreen
force-pushed
the
Stop-referencing-`snapshot`s-in-Brew-`conflicts-with`
branch
from
ee9a855
to
802de78
Compare
In https://hazelcast.atlassian.net/browse/DI-209 we updated the references in _existing_ files, but the generation script is still producing new files in this format. Fixes: [DI-238]( https://hazelcast.atlassian.net/browse/DI-238)
nishaatr
requested changes
Aug 14, 2024
ldziedziul
reviewed
Aug 14, 2024
That looks to be an existing issue - https://github.com/hazelcast/hazelcast-packaging/actions/runs/9823979811/job/27122462606 I'll have a look. EDIT - #223 |
JackPGreen
added a commit
that referenced
this pull request
Aug 14, 2024
[It was highlighted](#222 (review)) that a warning was logged: > packages/brew/functions.sh: line 10: $2: unbound variable - This should've been an error, not a warning - hence `set -u` - The function is clearly designed for `$2` to be optional, so we should support that
JackPGreen
added a commit
that referenced
this pull request
Aug 14, 2024
[It was highlighted](#222 (review)) that a warning was logged: > packages/brew/functions.sh: line 10: $2: unbound variable - This should've been an error, not a warning - hence `set -u` - The function is clearly designed for `$2` to be optional, so we should support that Warning [no longer logged](https://github.com/hazelcast/hazelcast-packaging/actions/runs/10395262076/job/28786894660).
nishaatr
approved these changes
Aug 15, 2024
JackPGreen
deleted the
Stop-referencing-`snapshot`s-in-Brew-`conflicts-with`
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://hazelcast.atlassian.net/browse/DI-209 we updated the references in existing files, but the generation script is still producing new files in this format.
Fixes: DI-238