Skip to content

Commit

Permalink
Fix deploy-snapshot.yml GitHub action (#304)
Browse files Browse the repository at this point in the history
[`deploy-snapshot.yml` consistently
fails](https://github.com/hazelcast/hazelcast-jdbc/actions/workflows/deploy-snapshot.yml)
with error:
```
Failed to execute goal
org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork (default)
on project hazelcast-jdbc-core: Presumably you have configured
maven-source-plugn to execute twice times in your build. You have to
configure a classifier for at least on of them.
```

This is because two different `maven-source-plugin` are configured with
different `id`s and `goal`s.

Changes:
- Unify `maven-source-plugin` configurations
   - `id`s
   - `goal`s
- Specify `license-maven-plugin` version
   - resolves `'build.plugins.plugin.version' for
org.codehaus.mojo:license-maven-plugin is missing.`
  • Loading branch information
JackPGreen committed Jan 23, 2024
1 parent eb46776 commit 61e33f7
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
1 change: 0 additions & 1 deletion hazelcast-jdbc-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
<dependency>
<groupId>org.assertj</groupId>
<artifactId>assertj-core</artifactId>
<version>3.25.1</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
10 changes: 8 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
<dependency>
<groupId>org.assertj</groupId>
<artifactId>assertj-core</artifactId>
<version>${assertj.version}</version>
<version>3.25.1</version>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down Expand Up @@ -194,7 +194,7 @@
<execution>
<id>attach-sources</id>
<goals>
<goal>jar</goal>
<goal>jar-no-fork</goal>
</goals>
</execution>
</executions>
Expand Down Expand Up @@ -232,6 +232,11 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>license-maven-plugin</artifactId>
<version>2.3.0</version>
</plugin>
</plugins>
</pluginManagement>
</build>
Expand Down Expand Up @@ -474,6 +479,7 @@
<artifactId>maven-source-plugin</artifactId>
<executions>
<execution>
<id>attach-sources</id>
<goals>
<goal>jar-no-fork</goal>
</goals>
Expand Down

0 comments on commit 61e33f7

Please sign in to comment.