New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test JDK version as part of PR builder [DI-317] [5.3.z] #818

Open

JackPGreen wants to merge 2 commits into 5.3.z from 5.3.z-DI-317

Commits on Nov 5, 2024

Test JDK version as part of PR builder [DI-317] (#816 )

Adds additional assertion to the PR builder smoke test that the JDK is
the version expected for the image.

This is currently a _manual, post release_ check, moving earlier in the
cycle to catch defects earlier.

Fixes: [DI-317](https://hazelcast.atlassian.net/browse/DI-317)

Post merge actions:
- [ ] backport
- [ ] _Discuss_ if we remove the manual, post-release check?

[DI-317]:
https://hazelcast.atlassian.net/browse/DI-317?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

JackPGreen committed Nov 5, 2024

Split simple-smoke-test.sh to be used elsewhere [DI-215] (#790 )

`simple-smoke-test.sh` is a useful suite of tests to validate a packaged
Hazelcast instance - but is Docker-centric.

- Refactored to split the script into two halves:
- `abstract-simple-smoke-test` that tests against an abstract Hazelcast
instance
  - `simple-smoke-test` a Docker-specific implementation
- Refactored the metadata checks to search the instance's logs for the
variant and version (i.e. OSS/EE, `5.5.0` etc) rather than inspecting
the containers' filesystem
- an existing test elsewhere in the codebase already does this so we
already have some dependency on keeping the output consistent, although
I can't currently find the test in question
- Added extra coverage from [`hazelcast-packaging`'s
`check-hazelcast-health.sh`](https://github.com/hazelcast/hazelcast-packaging/blob/bd417d0604b57ae2f72234d8781929fdf86b0687/check-hazelcast-health.sh)

Required for [DI-215](https://hazelcast.atlassian.net/browse/DI-215)

[DI-215]:
https://hazelcast.atlassian.net/browse/DI-215?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

JackPGreen committed Nov 5, 2024