Test JDK version as part of PR builder [DI-317] #816
Merged
+28
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackPGreen
force-pushed
the
DI-317---Add-JDK-version-tests-to-existing-smoke-tests
branch
from
c869e6b
to
970a2a9
Compare
JackPGreen
changed the title
nishaatr
requested changes
Nov 4, 2024
What RHEL changes are you expecting? |
Add test when for RHEL build. |
ldziedziul
reviewed
Nov 4, 2024
Short answer - no. Long answer, from what I understand we build Docker images which we deploy to Docker Hub and RHEL seperately. This PR is about the scope of the testing of the images. Testing of the deployment is part of #813. |
nishaatr
approved these changes
Nov 4, 2024
ldziedziul
approved these changes
Nov 5, 2024
JackPGreen
deleted the
DI-317---Add-JDK-version-tests-to-existing-smoke-tests
branch
JackPGreen
added a commit
that referenced
this pull request
Nov 5, 2024
…g mode (#817) We already do this in _some_ places, make it consistent everywhere. Raised from [PR feedback](#816 (comment)).
JackPGreen
added a commit
that referenced
this pull request
Nov 5, 2024
Adds additional assertion to the PR builder smoke test that the JDK is the version expected for the image. This is currently a _manual, post release_ check, moving earlier in the cycle to catch defects earlier. Fixes: [DI-317](https://hazelcast.atlassian.net/browse/DI-317) Post merge actions: - [ ] backport - [ ] _Discuss_ if we remove the manual, post-release check? [DI-317]: https://hazelcast.atlassian.net/browse/DI-317?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
JackPGreen
added a commit
that referenced
this pull request
Nov 5, 2024
Adds additional assertion to the PR builder smoke test that the JDK is the version expected for the image. This is currently a _manual, post release_ check, moving earlier in the cycle to catch defects earlier. Fixes: [DI-317](https://hazelcast.atlassian.net/browse/DI-317) Post merge actions: - [ ] backport - [ ] _Discuss_ if we remove the manual, post-release check? [DI-317]: https://hazelcast.atlassian.net/browse/DI-317?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
JackPGreen
added a commit
that referenced
this pull request
Nov 5, 2024
Adds additional assertion to the PR builder smoke test that the JDK is the version expected for the image. This is currently a _manual, post release_ check, moving earlier in the cycle to catch defects earlier. Fixes: [DI-317](https://hazelcast.atlassian.net/browse/DI-317) Post merge actions: - [ ] backport - [ ] _Discuss_ if we remove the manual, post-release check? [DI-317]: https://hazelcast.atlassian.net/browse/DI-317?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
This was referenced Nov 5, 2024
JackPGreen
added a commit
that referenced
this pull request
Nov 5, 2024
Adds additional assertion to the PR builder smoke test that the JDK is the version expected for the image. This is currently a _manual, post release_ check, moving earlier in the cycle to catch defects earlier. Fixes: [DI-317](https://hazelcast.atlassian.net/browse/DI-317) Post merge actions: - [ ] backport - [ ] _Discuss_ if we remove the manual, post-release check? [DI-317]: https://hazelcast.atlassian.net/browse/DI-317?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
JackPGreen
added a commit
that referenced
this pull request
Nov 5, 2024
…g mode (#817) We already do this in _some_ places, make it consistent everywhere. Raised from [PR feedback](#816 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional assertion to the PR builder smoke test that the JDK is the version expected for the image.
This is currently a manual, post release check, moving earlier in the cycle to catch defects earlier.
Fixes: DI-317
Post merge actions: