Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GitHub actions to avoid deprecated node warnings #113

Conversation

JackPGreen
Copy link
Contributor

@JackPGreen JackPGreen commented Jul 10, 2024

Recent builds have produced warnings:

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-python@v2, actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Upgrade checkout and setup-python to the latest versions to resolve.

[Recent builds](https://github.com/hazelcast/client-compatibility-suites/actions/runs/9872933102) have produced warnings:
```
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-python@v2, actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
```

Upgrade `checkout` and `setup-python` to the latest versions to resolve.
@JackPGreen JackPGreen requested a review from srknzl July 10, 2024 11:04
@JackPGreen JackPGreen self-assigned this Jul 10, 2024
Copy link
Member

@srknzl srknzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is ok in theory but I think we should run server compat tests to verify it's not broken (after we fix current failures of course)

@JackPGreen JackPGreen changed the title Upgrade GitHub actions to avoid deprecated node12 warning Upgrade GitHub actions to avoid deprecated node warnings Jul 10, 2024
@JackPGreen
Copy link
Contributor Author

Moving to #120 so I can test the actions against a branch in the repo, not a fork

@JackPGreen JackPGreen closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants