Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect types used on unsubscription_settings #9

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

daniel-chambers
Copy link
Collaborator

@daniel-chambers daniel-chambers commented Feb 28, 2024

Group ID types are supposed to actually be integers:

image

This PR also adds to CI to enable automatic releases on tagged revisions.

Copy link
Contributor

@sordina sordina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Love the CI change.

Comment on lines -456 to +460
r#type: named("String"),
r#type: named("Int"),
description: Some(String::from("The unsubscribe group to associate with this email."))
}),
(String::from("groups_to_display"), ObjectField {
r#type: nullable(array_of(named("group_id"))),
r#type: nullable(array_of(named("Int"))),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@daniel-chambers daniel-chambers merged commit 00cf723 into main Feb 28, 2024
2 checks passed
@daniel-chambers daniel-chambers deleted the fix-unsubscription-types branch February 28, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants