fix: Drop support for retiring E-Commerce Service accounts #37
Conversation
This never worked, and can't ever work, due to limitations in the E-Commerce service itself. Thus, rather than rely on whether ECOMMERCE_HOST is defined to decide whether the retirement pipeline for that service should be enabled, always disable it. Also, update the README explaining that this plugin can't be used to retire E-Commerce accounts. Fixes hastexo#36.
Not if it's for the purpose of supporting ecommerce. The discussion in #36 makes me think people shouldn't be touching it with a ten-foot pole, so I am much more comfortable with the idea of dropping support for it altogether. |
| @@ -3,13 +3,11 @@ client_secret: {{ RETIREMENT_EDX_OAUTH2_CLIENT_SECRET }} | |||
|
|
|||
| base_urls: | |||
| lms: {{ "https" if ENABLE_HTTPS else "http" }}://{{ LMS_HOST }} | |||
| {% if ECOMMERCE_HOST is defined %}ecommerce: {{ "https" if ENABLE_HTTPS else "http" }}://{{ ECOMMERCE_HOST }}{% endif %} | |||
There was a problem hiding this comment.
I'm not sure how important this is to the community, but if you remove this it may impact the ability to retire all of the Segment IDs. I've got doubts if anyone in the community is using ecommerce + segment + tutor, but thought I'd mention it.
tl;dr: ecommerce can maintain a separate user id just for interacting with Segment. If the retirement config sets fetch_ecommerce_segment_id to True and includes the Segment retirement step, the scripts will query Ecommerce for this id and the segment_api will retire it along with the other things that get deleted from Segment. This is what the ecommerce retirement API that we were looking at in the other issue handles.
There was a problem hiding this comment.
@bmtcril We maintain a community Tutor plugin here. If ecommerce is, as you say, in such a state that a reasonable Open edX community deployment shouldn't be using it at all, and the retirement pipeline for it is in such a state that there is effectively no retirement for ecommerce at all, then I don't see any impetus for a community plugin to support it. Much less support something related to the integration of that thing with a third-party service.
I'd much prefer we explicitly not support it, so that people who are brave (reckless?) enough to use ecommerce (with or without Segment) know that they're on their own as far as retirement for those services is concerned.
This never worked, and can't ever work, due to limitations in the E-Commerce service itself.
Thus, rather than rely on whether
ECOMMERCE_HOSTis defined to decide whether the retirement pipeline for that service should be enabled, always disable it.Also, update the README explaining that this plugin can't be used to retire E-Commerce accounts.
Fixes #36.