Refactored code and merged users/Lezune/Foundations-ImageGenerations-…

…UnauthorizedImageGenerationException-Update branch
hassanhabib · Jun 10, 2024 · 3ff3a82 · 3ff3a82
2 parents 35a46dc + 99f86df
commit 3ff3a82
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 14 deletions.
diff --git a/.../Services/Foundations/ImageGenerations/Exceptions/UnauthorizedImageGenerationException.cs b/.../Services/Foundations/ImageGenerations/Exceptions/UnauthorizedImageGenerationException.cs
@@ -9,12 +9,6 @@ namespace Standard.AI.OpenAI.Models.Services.Foundations.ImageGenerations.Except
 {
     public class UnauthorizedImageGenerationException : Xeption
     {
-        public UnauthorizedImageGenerationException(Exception innerException)
-            : base(
-                message: "Unauthorized image generation request, fix errors and try again.",
-                    innerException: innerException)
-        { }
-
         public UnauthorizedImageGenerationException(string message, Exception innerException)
             : base(message, innerException)
         { }

diff --git a/...dard.AI.OpenAI/Services/Foundations/ImageGenerations/ImageGenerationService.Exceptions.cs b/...dard.AI.OpenAI/Services/Foundations/ImageGenerations/ImageGenerationService.Exceptions.cs
@@ -44,15 +44,19 @@ private async ValueTask<ImageGeneration> TryCatch(ReturningImageGenerationFuncti
             catch (HttpResponseUnauthorizedException httpResponseUnauthorizedException)
             {
                 var unauthorizedImageGenerationException =
-                    new UnauthorizedImageGenerationException(httpResponseUnauthorizedException);
+                    new UnauthorizedImageGenerationException(
+                        message: "Unauthorized image generation request, fix errors and try again.", 
+                        httpResponseUnauthorizedException);
 
                 throw CreateImageGenerationDependencyException(
                     unauthorizedImageGenerationException);
             }
             catch (HttpResponseForbiddenException httpResponseForbiddenException)
             {
                 var unauthorizedImageGenerationException =
-                    new UnauthorizedImageGenerationException(httpResponseForbiddenException);
+                    new UnauthorizedImageGenerationException(
+                        message: "Unauthorized image generation request, fix errors and try again.", 
+                        httpResponseForbiddenException);
 
                 throw CreateImageGenerationDependencyException(
                     unauthorizedImageGenerationException);
@@ -104,12 +108,17 @@ private async ValueTask<ImageGeneration> TryCatch(ReturningImageGenerationFuncti
                         message: "Failed image generation service error occurred, contact support.", 
                         exception);
 
-                throw new ImageGenerationServiceException(
-                    message: "Image generation service error occurred, contact support.", 
-                    failedImageGenerationServiceException);
+                throw CreateImageGenerationServiceException(failedImageGenerationServiceException);
             }
         }
 
+        private static ImageGenerationValidationException CreateImageGenerationValidationException(Xeption innerException)
+        {
+            return new ImageGenerationValidationException(
+                message: "Image generation validation error occurred, fix errors and try again.",
+                innerException);
+        }
+
         private static ImageGenerationDependencyException CreateImageGenerationDependencyException(Xeption innerException)
         {
             return new ImageGenerationDependencyException(
@@ -124,10 +133,10 @@ private static ImageGenerationDependencyValidationException CreateImageGeneratio
                 innerException);
         }
 
-        private static ImageGenerationValidationException CreateImageGenerationValidationException(Xeption innerException)
+        private static ImageGenerationServiceException CreateImageGenerationServiceException(Exception innerException)
         {
-            return new ImageGenerationValidationException(
-                message: "Image generation validation error occurred, fix errors and try again.",
+            return new ImageGenerationServiceException(
+                message: "Image generation service error occurred, contact support.", 
                 innerException);
         }
     }