Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHC 9.10.1 to the versions tested in CI #105

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

BinderDavid
Copy link
Contributor

I used haskell-ci from the current master branch of the haskell-ci repo, since the published version of haskell-ci doesn't support 9.10 yet.

@BinderDavid
Copy link
Contributor Author

Hmm, the CI failure seems to be a bug in haskell-ci: The update to jammy breaks older builds. I'll open an issue on the haskell-ci repo.

@BinderDavid
Copy link
Contributor Author

@andreasabel suggested to use his fork of haskell-ci. This fork uses ghcup for all versions of ghc instead of the hvr ppa. I think this is an acceptable alternative to waiting for haskell-ci upstream to implement a fix.

Since we don't have to fix anything for ghc-9.10 it might also be possible to bump the upper bound on base in a metadata revision.

@BinderDavid
Copy link
Contributor Author

@Mikolaj haskell-ci fixed this in upstream as well in haskell-CI/haskell-ci#730 . Do you want me to refresh the CI configuration, or is this ok for the moment?

@Mikolaj
Copy link
Member

Mikolaj commented Jun 10, 2024

@BinderDavid: if you have a spare moment, that sounds like a good thing to do. :)

@BinderDavid
Copy link
Contributor Author

@Mikolaj Done.

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mikolaj
Copy link
Member

Mikolaj commented Jun 10, 2024

Anything else before we merge?

@BinderDavid
Copy link
Contributor Author

No, I think this is fine. Can you do a metadata revision on Hackage to bump the upper bound on base? This would allow me to make eventlog2html compatible with 9.10.

@Mikolaj
Copy link
Member

Mikolaj commented Jun 10, 2024

I've done the revision. Please check in 1h if that's what you wanted and if Hackage serves it fine. Merging. Thank you!

@Mikolaj Mikolaj closed this Jun 10, 2024
@Mikolaj Mikolaj reopened this Jun 10, 2024
@Mikolaj Mikolaj merged commit 2168f61 into haskell:master Jun 10, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants