(repair webworkers) replace promise.resolve().then with setTimeout

- Turns out promise.resolve().then() doesn't actually accomplish the equivalent of a setImmediate. I was mislead by something online, oh well... setTimeout works. - The main simulation worker was breaking when you used the 'run' functionality because the thread would lock. A setTimeout (and previously, setImmediate) was needed to allow other events in the thread.
hashintel · Dec 12, 2023 · 526ef58 · 526ef58
1 parent 6eb3fdb
commit 526ef58
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/apps/sim-core/packages/core/src/components/BehaviorKeys/BehaviorKeysForm.tsx b/apps/sim-core/packages/core/src/components/BehaviorKeys/BehaviorKeysForm.tsx
@@ -112,7 +112,7 @@ export const BehaviorKeysForm: FC<{
 
   const onAddField = () => {
     setData((draft) => addField(draft, projection.length === 0));
-    Promise.resolve().then(() => {
+    setTimeout(() => {
       if (listRef.current) {
         scrollToEnd(listRef.current);
         focusLast();

diff --git a/apps/sim-core/packages/core/src/components/HashCore/Files/HashCoreFiles.tsx b/apps/sim-core/packages/core/src/components/HashCore/Files/HashCoreFiles.tsx
@@ -122,7 +122,7 @@ export const HashCoreFiles: FC = () => {
           /**
            * @todo don't rely on querying for ids for this
            */
-          Promise.resolve().then(() => {
+          setTimeout(() => {
             document
               .querySelector<HTMLLIElement>(`#${getDomIdByFileId(file.id)}`)
               ?.scrollIntoView({ block: "center", inline: "center" });

diff --git a/apps/sim-core/packages/core/src/components/HashRouter/Effect/routes.tsx b/apps/sim-core/packages/core/src/components/HashRouter/Effect/routes.tsx
@@ -36,7 +36,7 @@ const routes: HookRouter.RouteObject = {
    * @todo route handlers should be side effect free – handle this elsewhere
    */
   "/:buildstamp/index.html": () => {
-    Promise.resolve().then(() => {
+    setTimeout(() => {
       /**
        * hookrouter's navigate has a bug where it incorrectly strips queries
        * included in the path, so we have to separate them.

diff --git a/apps/sim-core/packages/core/src/components/Modal/Experiments/ExperimentModal.tsx b/apps/sim-core/packages/core/src/components/Modal/Experiments/ExperimentModal.tsx
@@ -1391,7 +1391,7 @@ export const ExperimentModal: FC<{
 
                   fields.push(optimizationFieldTemplate());
                   setFormData(clone);
-                  Promise.resolve().then(() => {
+                  setTimeout(() => {
                     document
                       .querySelector<HTMLInputElement>(
                         `[name="fields.${fields.length - 1}.name"]`,

diff --git a/apps/sim-core/packages/core/src/components/ResourceListItem/Popup/ResourceListItemPopup.tsx b/apps/sim-core/packages/core/src/components/ResourceListItem/Popup/ResourceListItemPopup.tsx
@@ -60,7 +60,7 @@ const useRepositionPopoverOnElementResize = () =>
        */
       scrollBy(0, 1);
 
-      Promise.resolve().then(() => {
+      setTimeout(() => {
         scrollBy(0, -1);
       });
     },

diff --git a/apps/sim-core/packages/engine-web/src/engine-web/runners/actions.ts b/apps/sim-core/packages/engine-web/src/engine-web/runners/actions.ts
@@ -53,7 +53,7 @@ const runSim = async (runner: RunnerState) => {
     runner.stepsLeft -= 1;
 
     // awaiting the runner might be instant, so we need to prevent the thread from locking
-    await new Promise((resolve) => Promise.resolve().then(resolve));
+    await new Promise((resolve) => setTimeout(resolve));
 
     if (runner.stepHandler) {
       await runner.stepHandler(runner.stepsTaken + 1, newState);