-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H-2959, H-3368: Implement a Value
data type and make all data types inherit from it
#5240
Merged
TimDiekmann
merged 17 commits into
main
from
t/h-2959-implement-a-value-data-type-and-make-all-data-types-inherit
Oct 1, 2024
Merged
H-2959, H-3368: Implement a Value
data type and make all data types inherit from it
#5240
TimDiekmann
merged 17 commits into
main
from
t/h-2959-implement-a-value-data-type-and-make-all-data-types-inherit
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/deps
Relates to third-party dependencies (area)
area/apps > hash*
Affects HASH (a `hash-*` app)
area/apps > hash-api
Affects the HASH API (app)
area/libs
Relates to first-party libraries/crates/packages (area)
type/eng > backend
Owned by the @backend team
area/tests
New or updated tests
area/apps
area/apps > hash-graph
labels
Sep 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5240 +/- ##
==========================================
+ Coverage 20.18% 20.23% +0.04%
==========================================
Files 510 508 -2
Lines 17300 17260 -40
Branches 2546 2537 -9
==========================================
Hits 3492 3492
+ Misses 13770 13730 -40
Partials 38 38 ☔ View full report in Codecov by Sentry. |
TimDiekmann
changed the title
H-2959: Implement a
H-2959, H-3368: Implement a Sep 27, 2024
Value
data type and make all data types inherit from itValue
data type and make all data types inherit from it
TimDiekmann
force-pushed
the
t/h-2958-extend-type-system-crate-to-support-extended-custom-data
branch
from
September 27, 2024 10:50
3e7252a
to
d159b3d
Compare
TimDiekmann
force-pushed
the
t/h-2959-implement-a-value-data-type-and-make-all-data-types-inherit
branch
from
September 27, 2024 14:07
9938cd9
to
c5bfb3b
Compare
github-actions
bot
added
the
area/tests > integration
New or updated integration tests
label
Sep 28, 2024
CiaranMn
reviewed
Sep 29, 2024
apps/hash-graph/libs/type-fetcher/predefined_types/data_types/value_v1.json
Outdated
Show resolved
Hide resolved
Base automatically changed from
t/h-2958-extend-type-system-crate-to-support-extended-custom-data
to
main
September 29, 2024 14:31
…ype-and-make-all-data-types-inherit # Conflicts: # apps/hash-graph/libs/graph/src/store/validation.rs
Benchmark results
|
Function | Value | Mean | Flame graphs |
---|---|---|---|
entity_by_property | depths: DT=0, PT=2, ET=2, E=2 | Flame Graph | |
entity_by_property | depths: DT=0, PT=0, ET=2, E=2 | Flame Graph | |
entity_by_property | depths: DT=0, PT=0, ET=0, E=2 | Flame Graph | |
entity_by_property | depths: DT=255, PT=255, ET=255, E=255 | Flame Graph | |
entity_by_property | depths: DT=2, PT=2, ET=2, E=2 | Flame Graph | |
entity_by_property | depths: DT=0, PT=0, ET=0, E=0 | Flame Graph | |
link_by_source_by_property | depths: DT=0, PT=2, ET=2, E=2 | Flame Graph | |
link_by_source_by_property | depths: DT=0, PT=0, ET=2, E=2 | Flame Graph | |
link_by_source_by_property | depths: DT=0, PT=0, ET=0, E=2 | Flame Graph | |
link_by_source_by_property | depths: DT=255, PT=255, ET=255, E=255 | Flame Graph | |
link_by_source_by_property | depths: DT=2, PT=2, ET=2, E=2 | Flame Graph | |
link_by_source_by_property | depths: DT=0, PT=0, ET=0, E=0 | Flame Graph |
representative_read_entity
Function | Value | Mean | Flame graphs |
---|---|---|---|
entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1
|
Flame Graph | |
entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1
|
Flame Graph | |
entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1
|
Flame Graph | |
entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2
|
Flame Graph | |
entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1
|
Flame Graph | |
entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1
|
Flame Graph | |
entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1
|
Flame Graph | |
entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1
|
Flame Graph | |
entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1
|
Flame Graph |
representative_read_entity_type
Function | Value | Mean | Flame graphs |
---|---|---|---|
get_entity_type_by_id | Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579
|
Flame Graph |
scaling_read_entity_complete_zero_depth
Function | Value | Mean | Flame graphs |
---|---|---|---|
entity_by_id | 10 entities | Flame Graph | |
entity_by_id | 25 entities | Flame Graph | |
entity_by_id | 5 entities | Flame Graph | |
entity_by_id | 50 entities | Flame Graph | |
entity_by_id | 1 entities | Flame Graph |
scaling_read_entity_complete_one_depth
Function | Value | Mean | Flame graphs |
---|---|---|---|
entity_by_id | 10 entities | Flame Graph | |
entity_by_id | 25 entities | Flame Graph | |
entity_by_id | 5 entities | Flame Graph | |
entity_by_id | 50 entities | Flame Graph | |
entity_by_id | 1 entities | Flame Graph |
scaling_read_entity_linkless
Function | Value | Mean | Flame graphs |
---|---|---|---|
entity_by_id | 10000 entities | Flame Graph | |
entity_by_id | 10 entities | Flame Graph | |
entity_by_id | 100 entities | Flame Graph | |
entity_by_id | 1000 entities | Flame Graph | |
entity_by_id | 1 entities | Flame Graph |
CiaranMn
approved these changes
Oct 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 1, 2024
TimDiekmann
deleted the
t/h-2959-implement-a-value-data-type-and-make-all-data-types-inherit
branch
October 1, 2024 14:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/apps > hash*
Affects HASH (a `hash-*` app)
area/apps > hash-api
Affects the HASH API (app)
area/apps > hash-graph
area/apps
area/deps
Relates to third-party dependencies (area)
area/libs
Relates to first-party libraries/crates/packages (area)
area/tests > integration
New or updated integration tests
area/tests
New or updated tests
type/eng > backend
Owned by the @backend team
type/eng > frontend
Owned by the @frontend team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
Every data type should inherit (directly or indirectly) from
Value
.🚫 Blocked by
anyOf
in type system #5232🔍 What does this change?
Value
data type definitions:Value
empty-list
type to useitems: false
instead ofconst: []
const
for array schemasValue
)Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
The production instance needs to be patched to read the new data
📹 Demo