Enhance default manifests in helm chart #900
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helm chart currently contains some templates to deploy default resources for
VaultConnectionandVaultAuth. Since the operator also supports a defaultVaultAuthGlobalresource in the namespaces of the controller, it would be great to have a template for that as well.Additionally, it would be convenient to have a possibility to install some generic manifests together with the helm chart. This could be used for example to install a Secret containing the vault ca-certificate, which is required by the default
VaultConnection. There might also be other use-cases where generics manifests are helpful.Please let me know what you think about these changes.