VSS/instant-updates: more stable event watcher #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass a dereferenced VSS object to the vault event watcher goroutine to avoid the effect of the VSS object being garbage collected before the goroutine is started/evaluated
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass a dereferenced VSS object to the vault event watcher goroutine to avoid the
EventWatcherStartedk8s event being emitted without a name or namespace. Also wait for theEventWatcherStartedk8s event before proceeding with the instant updates tests, to ensure the Vault event subscription is setup before the tests proceed with modifying Vault.Disclaimer: I'm not totally sure why passing a dereferenced VSS object seems to fix the issue. I thought maybe it was something to do with garbage collection, but I haven't been able to confirm that suspicion.