Core: ensure unneeded Vault clients are pruned from the cache #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benashz
changed the title
benashz
force-pushed
the
VAULT-27944/core-prune-orphaned-vault-clients
branch
2 times, most recently
from
46f076a
to
e0e3ddc
Compare
benashz
changed the title
Previously, the CachingClientFactory would keep all cached Vault Clients alive even if no longer had any referring objects. This change adds a new periodic function that will prune any Vault client that has no referring objects. - Don't prune new clients.
benashz
force-pushed
the
VAULT-27944/core-prune-orphaned-vault-clients
branch
from
2b35af5
to
fe69075
Compare
benashz
force-pushed
the
VAULT-27944/core-prune-orphaned-vault-clients
branch
from
fb5048c
to
21e5cb2
Compare
controllers: log status update errors
benashz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the CachingClientFactory would keep all cached Vault Clients alive even if no longer had any referring objects.
With this change the CachingClientFactory will track the number of objects that reference a specific Vault client. Any client that no longer has any references will be evicted from the cache.