Standardize use of testing-mocks.tfe for run_tasks_url between CI and Nightly tests
#1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en CI and Nightly tests. Fix failing tests using incorrect format for query params.
Maed223
force-pushed
the
test-tfe-mock-fix
branch
from
db07294
to
de567c3
Compare
Maed223
changed the title
run_tasks_url between CI and Nightly tests
ctrombley
reviewed
Sep 18, 2024
| "tfe_notification_configuration.foobar", "url", fmt.Sprintf("%s/?update=true", runTasksURL())), | ||
| "tfe_notification_configuration.foobar", "url", fmt.Sprintf("%s?update=true", runTasksURL())), |
There was a problem hiding this comment.
Don't worry it took me quite awhile to realize it myself 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up work to this PR that migrated away from using
example.comfor the testing run task url.Standardized use of
http://testing-mocks.tfe:22180/runtasks/passbetween CI and Nightly tests, as well as fixes for the failing tests that popped up from using this new URL. Turns out we were just incorrectly formatting certain query params.Testing plan
Fixed failing tests