Add tfe_projects data source

[tdevelioglu]

Description

Add tfe_projects data source for retrieving organization projects.

Testing plan

Create and retrieve projects with the new data source.

Example configuration

resource "tfe_organization" "organization" {
  name  = "random-org"
  email = "[email protected]"
}

resource "tfe_project" "project1" {
  name         = "project1"
  description  = "Project 1"
  organization = tfe_organization.organization.name
}

resource "tfe_project" "project2" {
  name        = "project2"
  description = "Project 2"
  organization = tfe_organization.organization.name
}

resource "tfe_project" "project3" {
  name        = "project3"
  description = "Project 3"
  organization = tfe_organization.organization.name
}

data tfe_projects "all" {
  organization = tfe_organization.organization.name
}

External links

• go-tfe documentation
• API documentation

Output from acceptance tests

$ TESTARGS="-run TestAccTFEProjects" make testacc
TF_ACC=1 TF_LOG_SDK_PROTO=OFF go test $(go list ./... |grep -v 'vendor') -v -run TestAccTFEProjects -timeout 15m
?       github.com/hashicorp/terraform-provider-tfe     [no test files]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-tfe/internal/client     (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-tfe/internal/logging    (cached) [no tests to run]
=== RUN   TestAccTFEProjectsDataSource_basic
--- PASS: TestAccTFEProjectsDataSource_basic (4.09s)
=== RUN   TestAccTFEProjectsDataSource_basicNoProjects
--- PASS: TestAccTFEProjectsDataSource_basicNoProjects (3.70s)
PASS
ok      github.com/hashicorp/terraform-provider-tfe/internal/provider   (cached)
?       github.com/hashicorp/terraform-provider-tfe/internal/provider/validators        [no test files]
?       github.com/hashicorp/terraform-provider-tfe/version     [no test files]
...

[hashicorp-cla-app]

All committers have signed the CLA.

[tdevelioglu]

Can this one be reviewed, or does it require any additional info ?

[hs26gill]

@tdevelioglu could you please provide feedback so we can proceed with the changes, thanks.

[netramali]

@tdevelioglu The test might fail because of the ordering of the 4 projects. Hence we need to do something like this:
Declare this array: prjNames := []string{"Default Project", prj1.Name, prj2.Name, prj3.Name}
and then

					resource.TestCheckResourceAttrWith(
						"data.tfe_projects.all", "projects.0.name", func(value string) error {
							for _, name := range prjNames {
								if name == value {
									return nil
								}
							}
							return fmt.Errorf("Excepted project name %s to be in the list %v but not found. ", value, prjNames)
						}),

instead of
resource.TestCheckResourceAttr(
"data.tfe_projects.all", "projects.0.name", "Default Project"),

[tdevelioglu]

Sure, but how do we check both description and name are correct ?

Related, I am unable to further testacc these changes myself due to lack of permission.

[netramali]

@tdevelioglu For description you will also have to create something like:
description := []string{"", prj1.Description, prj2.Description, prj3.Description}
and then

resource.TestCheckResourceAttrWith(
						"data.tfe_projects.all", "projects.0.description", func(value string) error {
							for _,description := range description {
								if description == value {
									return nil
								}
							}
							return fmt.Errorf("Excepted project description %s to be in the list %v but not found. ", value, description)
						}),

But to be honest, I think we can remove and ignore description from this test entirely since the purpose of this test is to check if project is returned or not.

[netramali]

If it helps, you can reference this: https://github.com/hashicorp/terraform-provider-tfe/pull/1506/files#diff-94dc573614fee0ef601ca30331d457363deb060c4ce0af0d93c51dff59f62943
Let me know if you are not able to access this.
I have confirm that the CI test passes with this.

[tdevelioglu]

I've dropped the description and order-dependent checks, can you check if this passes ?

[netramali]

I have opened another PR with your commits present. I'll look into the CI tests there and get it merged as soon as possible. We can close this PR now. Thank you for addressing the feedback!