Update test matrix to reflect latest Consul releases #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`main` is now the primary branch for this repo
nathancoleman
force-pushed
the
update-test-matrix
branch
from
8ba20b4
to
c7a855b
Compare
nathancoleman
commented
Aug 1, 2024
| @@ -595,6 +595,8 @@ resource "consul_config_entry" "service_intentions" { | |||
| name = consul_config_entry.sd.name | |||
| kind = "service-intentions" | |||
|
|
|||
| depends_on = [consul_config_entry.jwt_provider] | |||
There was a problem hiding this comment.
This keeps tf from trying to delete the jwt provider before the service intention has been deleted. Before, the tf destroy was failing because Consul won't allow the provider to be removed if any intentions still reference it.
| @@ -2,7 +2,7 @@ | |||
| resource "consul_certificate_authority" "connect" { | |||
| connect_provider = "consul" | |||
|
|
|||
| config_json = jsondecode({ | |||
| config_json = jsonencode({ | |||
There was a problem hiding this comment.
This appeared to be a typo from #341 , but please double-check me
There was a problem hiding this comment.
Yeah seems like an autocomplete mixup
| @@ -3,7 +3,7 @@ | |||
| page_title: "consul_acl_binding_rule Resource - terraform-provider-consul" | |||
| subcategory: "" | |||
| description: |- | |||
| Starting with Consul 1.5.0, the consulaclbinding_rule resource can be used to managed Consul ACL binding rules. | |||
| Starting with Consul 1.5.0, the consul_acl_binding_rule resource can be used to managed Consul ACL binding rules. | |||
There was a problem hiding this comment.
This is just a result of rerunning the docs generation process
zalimeni
approved these changes
Aug 1, 2024
|
Thank you for noticing and fixing this @nathancoleman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the tests in this repo haven't been running since the primary branch was switched from
mastertomain. Upon re-enabling them, there were a couple of failures that needed addressing around tf resource dependencies and generated docs.