Don't panic on missing role in consul_acl_role_policy_attachment #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`resourceConsulACLRolePolicyAttachmentCreate()` and `resourceConsulACLRolePolicyAttachmentDelete()` were not checking properly if the given role ID was not found in Consul. Some functions in the Consul SDK return an error when the object is missing, other return a `nil` object. In the case of `RoleRead()` I was checking for the wrong thing. I checked the rest of the ACL resources and as far as I know it, this was the only resource impacted. I also update the `consul_acl_policy` data source to use the new `PolicyReadByName()` function.
remilapeyre
changed the title
dhiaayachi
reviewed
Nov 20, 2023
Comment on lines
+59
to
+61
| if policy == nil { | ||
| return fmt.Errorf("could not find policy %q", name) | ||
| } |
There was a problem hiding this comment.
I just fixed the same bug in Consul CLI 😆
hashicorp/consul#19679
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resourceConsulACLRolePolicyAttachmentCreate()andresourceConsulACLRolePolicyAttachmentDelete()were not checking properly if the given role ID was not found in Consul.
Some functions in the Consul SDK return an error when the object is missing,
other return a
nilobject.In the case of
RoleRead()I was checking for the wrong thing. I checked therest of the ACL resources and as far as I know it, this was the only
resource impacted.
I also update the
consul_acl_policydata source to use the newPolicyReadByName()function.Closes #378