Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement consul_config_entry_service_splitter #364

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

remilapeyre
Copy link
Collaborator

Related to #316

remilapeyre added a commit to remilapeyre/terraform-provider-consul that referenced this pull request Oct 18, 2023
This resource makes it easier to manage a `sameness-group` config entry.
It builds on hashicorp#364
so should be reviewed and merged after it.

The importer implementation in `resourceFromConfigEntryImplementation()`
has also been updated to support the `"<name>" or "<partition>/<name>"`
ID format has `sameness-group` is not bound to a namespace.
Copy link
Contributor

@dhiaayachi dhiaayachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@remilapeyre remilapeyre merged commit cb7f9af into hashicorp:master Oct 24, 2023
4 checks passed
@remilapeyre remilapeyre deleted the service-splitter branch October 24, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants