Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the consul_acl_role_policy_attachment resource #362

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Implement the consul_acl_role_policy_attachment resource #362

merged 3 commits into from
Oct 24, 2023

Conversation

remilapeyre
Copy link
Collaborator

Closes #354

roncodingenthusiast
roncodingenthusiast approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@roncodingenthusiast roncodingenthusiast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

consul/resource_consul_acl_role_policy_attachment_test.go Outdated Show resolved Hide resolved
consul/resource_consul_acl_role_policy_attachment_test.go Outdated Show resolved Hide resolved
@remilapeyre remilapeyre merged commit 4154012 into hashicorp:master Oct 24, 2023
4 checks passed
@remilapeyre remilapeyre deleted the issue-354 branch October 24, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roncodingenthusiast roncodingenthusiast roncodingenthusiast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New consul_acl_role_policy_attachment resource
2 participants
@remilapeyre @roncodingenthusiast