Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Net 5676 - Service Defaults, Service Splitter, Service Resolver, Service Router and Service Intentions Resource In Terraform Consul Provider #355

Closed
wants to merge 102 commits into from
Closed

Net 5676 - Service Defaults, Service Splitter, Service Resolver, Service Router and Service Intentions Resource In Terraform Consul Provider #355

wants to merge 102 commits into from

Conversation

absolutelightning
Copy link
Contributor

@absolutelightning absolutelightning commented Sep 25, 2023 •
edited
Loading

Net 5676 - Service Defaults, Service Splitter, Service Resolver, Service Router and Service Intentions Resource In Terraform Consul Provider

Tested by CI and by terraform init and terraform apply

@absolutelightning absolutelightning marked this pull request as ready for review September 25, 2023 11:48
@remilapeyre remilapeyre self-requested a review September 25, 2023 12:11
Ganeshrockz
Ganeshrockz reviewed Sep 25, 2023
View reviewed changes
Copy link

@Ganeshrockz Ganeshrockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Will review the test files later on.

consul/resource_service_defaults_config_entry.go Outdated Show resolved Hide resolved
consul/resource_service_defaults_config_entry.go Outdated Show resolved Hide resolved
consul/resource_service_defaults_config_entry.go Outdated Show resolved Hide resolved
consul/resource_service_defaults_config_entry.go Outdated Show resolved Hide resolved
consul/resource_service_defaults_config_entry_ce_test.go Outdated Show resolved Hide resolved
@absolutelightning absolutelightning changed the title Net 5676 - Service Defaults Resouce In Terraform Consul Provider Net 5676 - Service Defaults Resource In Terraform Consul Provider Sep 26, 2023
@absolutelightning absolutelightning changed the title Net 5676 - Service Defaults Resource In Terraform Consul Provider Net 5676 - Service Defaults and Service Splitter Resource In Terraform Consul Provider Sep 26, 2023
Ganeshrockz
Ganeshrockz approved these changes Sep 26, 2023
View reviewed changes
Copy link

@Ganeshrockz Ganeshrockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

consul/helper.go Outdated Show resolved Hide resolved
consul/helper.go Outdated Show resolved Hide resolved
@absolutelightning absolutelightning changed the title Net 5676 - Service Defaults and Service Splitter Resource In Terraform Consul Provider WIP - Net 5676 - Service Defaults and Service Splitter Resource In Terraform Consul Provider Oct 4, 2023
@absolutelightning absolutelightning changed the title WIP - Net 5676 - Service Defaults and Service Splitter Resource In Terraform Consul Provider WIP - Net 5676 - Service Defaults, Service Splitter, Service Resolver, Service Router and Service Intentions Resource In Terraform Consul Provider Oct 4, 2023
absolutelightning and others added 15 commits October 4, 2023 15:33
@absolutelightning
fix resource provider
bee3491
@absolutelightning
fix intentinos schema
56cc862
@absolutelightning
fix intentions
28bd93e
@absolutelightning
intentions fixes
5ac3ed7
@absolutelightning
intentions test
31aec22
@hashicorp-copywrite @remilapeyre
[COMPLIANCE] Add Copyright and License Headers (hashicorp#353)
3b703a9 
Co-authored-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com>
Co-authored-by: Rémi Lapeyre <[email protected]>
@remilapeyre
Fix consul_service resource documentation (hashicorp#352)
bb9bac0 
Closes hashicorp#350
@am-ak @remilapeyre
Indicate that max_token_ttl is required for OIDC auth methods (hashic…
656eb65 
…orp#360)

Co-authored-by: Rémi Lapeyre <[email protected]>
@remilapeyre
Fix consul_config_entry_service_router tests
c0afbe9
@remilapeyre
Merge remote-tracking branch 'origin/master' into absolutelightning-N…
4e3b4e5 
…ET-5676
@absolutelightning
service router ee test
65c97db
@absolutelightning
fix intentnios
d05516b
@absolutelightning
make intentinos tests passing
d323696
@absolutelightning
update tests
0e691fb
@absolutelightning
fix tests
ca04233
@absolutelightning absolutelightning changed the title WIP - Net 5676 - Service Defaults, Service Splitter, Service Resolver, Service Router and Service Intentions Resource In Terraform Consul Provider Net 5676 - Service Defaults, Service Splitter, Service Resolver, Service Router and Service Intentions Resource In Terraform Consul Provider Oct 9, 2023
@remilapeyre remilapeyre marked this pull request as draft October 9, 2023 13:39
@remilapeyre
Copy link
Collaborator

Hello @absolutelightning , I'm closing this pull request since the functionality has already been merged in the other PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remilapeyre remilapeyre remilapeyre requested changes

@Ganeshrockz Ganeshrockz Ganeshrockz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@absolutelightning @remilapeyre @Ganeshrockz @am-ak