Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs, examples and tests for jwt-provider config entry and jwt referencing intentions #349

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Add docs, examples and tests for jwt-provider config entry and jwt referencing intentions #349

merged 1 commit into from
Jul 14, 2023

Conversation

roncodingenthusiast
Copy link
Contributor

@roncodingenthusiast roncodingenthusiast commented Jul 13, 2023 •
edited
Loading

This PR:

@roncodingenthusiast roncodingenthusiast changed the title WIP: add tests for jwt-provider config entry Add docs, examples and tests for jwt-provider config entry and jwt referencing intentions Jul 13, 2023
@roncodingenthusiast roncodingenthusiast marked this pull request as ready for review July 13, 2023 17:56
@roncodingenthusiast
Copy link
Contributor Author

cc @dhiaayachi @remilapeyre for 👀 and review ✅

dhiaayachi
dhiaayachi approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@dhiaayachi dhiaayachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dhiaayachi dhiaayachi merged commit b52c292 into hashicorp:master Jul 14, 2023
@roncodingenthusiast roncodingenthusiast deleted the NET-3099 branch July 14, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhiaayachi dhiaayachi dhiaayachi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roncodingenthusiast @dhiaayachi